Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation warnings #1731

Merged
merged 6 commits into from Mar 14, 2018
Merged

Commits on Mar 4, 2018

  1. tweak compiler flags to reduce noise

    remove a few that generate lots of warnings on ruby.h:
    - -Wcast-qual
    - -Wconversion
    
    add -Wextra back (it was removed in 2008)
    flavorjones committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    77be60c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b0a12b9 View commit details
    Browse the repository at this point in the history
  3. replace namespace_eh function with a macro

    to fix compiler warnings.
    
    the node->type check is polymorphic, and so a macro makes more sense to
    me (so we get some compile-time checking) than force-typecasting.
    flavorjones committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    0b9c828 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. Configuration menu
    Copy the full SHA
    ca22ccb View commit details
    Browse the repository at this point in the history
  2. Fix one remaining warning about const qualifier

    xmlNewCDataBlock() takes ptr and len, so we can use RSTRING_LEN()
    instead of strlen(). strlen() was introduced in commit c766f6e
    to fix a segfault, but it's enough to execute StringValuePtr() and
    RSTRING_LEN() in order to avoid invalid memory access.
    larskanis committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    d78c447 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1735 from larskanis/flavorjones-fix-compilation-w…

    …arnings
    
    Flavorjones fix compilation warnings
    flavorjones committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    c93fa43 View commit details
    Browse the repository at this point in the history