test Windows gem installation (from source / using Devkit) #2153
Labels
Milestone
Comments
flavorjones
added a commit
that referenced
this issue
Mar 8, 2021
…g-on-windows fix nokogumbo linking on windows --- **What problem is this PR intended to solve?** Closes #2167 which relates to an issue building Nokogumbo on Windows against the precompiled libraries. This PR does the following: - ensures that libxml2 symbols are exported when built on windows - ensures that nokogiri symbols are exported when built on windows - includes `LDFLAGS` in `Nokogiri::VERSION_INFO` to allow the windows linker to resolve all symbols **Have you included adequate test coverage?** There's pretty good test coverage of this test case in the Nokogumbo CI suite; and I've added some light tests here in `scripts/test-gem-installation` though I'll note that we're not testing gem installation on Windows in the Nokogiri CI suite at the moment (though, see #2153). **Does this change affect the behavior of either the C or the Java implementations?** This should only impact downstream gems like Nokogumbo who are trying to link against the precompiled Nokogiri libraries.
|
#2244 provides this test coverage |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(extracted from #1845)
In order to have more confidence in the Windows experience we're shipping, I'd like to test installation of Windows gems from source -- using Devkit -- in CI. Currently we only have coverage for "ruby" platform gem installation on Linux.
The text was updated successfully, but these errors were encountered: