Make builds minimal #1719
Make builds minimal #1719
Conversation
|
This seems alright to me. Agree with @flavorjones that it's sometimes helpful to have the tests, but I also don't feel strongly about it (especially since we tag the release version in git anyway). |
|
OK - I agree in principle with minimizing the gem; however I want to make sure I have automated testing of the generated gem to ensure that we're not omitting necessary files. This is at the top of my TODO list. |
@flavorjones thank you for the working with this. How was the status? |
|
Making gems minimal in size sounds good to me as long as not too much is removed. E.g., #1788 wants the headers installed in the extension directory or at least not removed. Until that (or something like it) happens, Nokogumbo is actually using the |
stevecrozz
force-pushed
the
minimal-build
branch
3 times, most recently
from
9660dff
to
7462bd5
Compare
|
I've rebased this branch onto most recent master and @stevecheckoway I have restored dependencies.yml to Manifest.txt as it sounds like gems may depend on it. |
Manifest.txt
Outdated
| @@ -256,6 +238,7 @@ patches/libxml2/0003-Fix-infinite-loop-in-LZMA-decompression.patch | |||
| patches/sort-patches-by-date | |||
| suppressions/README.txt | |||
| suppressions/nokogiri_ruby-2.supp | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
We can remove git conflict mark here.
Manifest.txt
Outdated
| @@ -368,3 +351,5 @@ test/xml/test_xinclude.rb | |||
| test/xml/test_xpath.rb | |||
| test/xslt/test_custom_functions.rb | |||
| test/xslt/test_exception_handling.rb | |||
| ======= | |||
| >>>>>>> Make builds minimal | |||
There was a problem hiding this comment.
We can remove git conflict mark here.
stevecrozz
force-pushed
the
minimal-build
branch
from
7462bd5
to
013f869
Compare
|
Thanks @junaruga. Updated. |
|
@stevecrozz Can you please rebase on master? We fixed some things in 464717b related to JRuby 9.2 backwards incompatibilities that are making this PR fail tests on JRuby 9.2. |
stevecrozz
force-pushed
the
minimal-build
branch
from
013f869
to
95bf7de
Compare
|
No prob @flavorjones. I force-pushed a newly rebased branch. |
|
Woo, that went green. OK, I may try to get this into v1.9.0. Thanks! |
|
I've merged this manually! Will be in v1.9.0. Thanks again for your patience and for submitting this PR! |
This is in reference to #1711 where I suggest we package minimal builds that only include the essentials. This change saves me about 2MiB on disk which sounds like nothing, but on my alpine linux Docker images its actually significant. Since we started discussing already, its probably best to talk about the general idea of removing non-essential files from the build in #1711, but here's a concrete example of what I'm thinking.