Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test files from the final gem #166

Closed
flavorjones opened this issue Apr 23, 2019 · 1 comment
Closed

Remove test files from the final gem #166

flavorjones opened this issue Apr 23, 2019 · 1 comment
Milestone
v2.5.0

Comments

@flavorjones
Copy link
Owner

See #159 for the original request, and see sparklemotion/nokogiri#1719 for similar work done on the Nokogiri gem.

Also see sparklemotion/nokogiri#1855 for some unhappiness related to this decision, as it affected downstream packaging (e.g., linux distro packages).
@flavorjones flavorjones added this to the v3.0.0 milestone Sep 28, 2019
@JuanitoFatas JuanitoFatas mentioned this issue Nov 27, 2019
Closed
@flavorjones flavorjones mentioned this issue Nov 29, 2019
Merged
@flavorjones flavorjones modified the milestones: v3.0.0, v2.5.0 Nov 29, 2019
@flavorjones
Copy link
Owner Author

Closed by #180.

This was referenced Mar 11, 2021
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Remove test files from final gem JuanitoFatas/loofah
1 participant
@flavorjones