Adding test coverage

to make sure we're testing validation of invalid files. Related to #1351.
sparklemotion · Sep 15, 2015 · ebdb95b · twalpole · Sep 22, 2015 · ebdb95b
1 parent 66fcc00
commit ebdb95b
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/test/xml/test_schema.rb b/test/xml/test_schema.rb
@@ -94,9 +94,22 @@ def test_validate_file
       end
 
       def test_validate_invalid_document
-        read_doc = File.read(PO_XML_FILE).gsub(/<city>[^<]*<\/city>/, '')
+        doc = Nokogiri::XML File.read(PO_XML_FILE)
+        doc.css("city").unlink
 
-        assert errors = @xsd.validate(Nokogiri::XML(read_doc))
+        assert errors = @xsd.validate(doc)
+        assert_equal 2, errors.length
+      end
+
+      def test_validate_invalid_file
+        tempfile = Tempfile.new("xml")
+
+        doc = Nokogiri::XML File.read(PO_XML_FILE)
+        doc.css("city").unlink
+        tempfile.write doc.to_xml
+        tempfile.close
+
+        assert errors = @xsd.validate(tempfile.path)
         assert_equal 2, errors.length
       end