CSS selector :has() matches against deep descendants

Fixes #350.
sparklemotion · Jan 5, 2019 · c7fc1dc · c7fc1dc
1 parent a684202
commit c7fc1dc
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,11 @@
 * [MRI] Handle Xcode 10's new library path on macOS. [#1801, #1851] (Thanks, @mlj and @deepj!)
 
 
+### Bug fixes
+
+* CSS selector `:has()` correctly matches against any descendant (previously matched against only direct children). [#350] (Thanks, @Phrogz!)
+
+
 ## 1.10.0 / 2019-01-04
 
 ### Features

diff --git a/lib/nokogiri/css/xpath_visitor.rb b/lib/nokogiri/css/xpath_visitor.rb
@@ -51,7 +51,7 @@ def visit_function node
         when /^comment\(/
           "comment()"
         when /^has\(/
-          node.value[1].accept(self)
+          ".//#{node.value[1].accept(self)}"
         else
           args = ['.'] + node.value[1..-1]
           "#{node.value.first}#{args.join(', ')})"

diff --git a/test/css/test_parser.rb b/test/css/test_parser.rb
@@ -63,8 +63,8 @@ def test_to_a
       end
 
       def test_has
-        assert_xpath  "//a[b]", @parser.parse("a:has(b)")
-        assert_xpath  "//a[b/c]", @parser.parse("a:has(b > c)")
+        assert_xpath  "//a[.//b]", @parser.parse("a:has(b)")
+        assert_xpath  "//a[.//b/c]", @parser.parse("a:has(b > c)")
       end
 
       def test_dashmatch