style(rubocop): Style/MapIntoArray

sparklemotion · Apr 15, 2024 · b7b0833 · b7b0833
1 parent 1ce2334
commit b7b0833
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/test/xml/node/test_attribute_methods.rb b/test/xml/node/test_attribute_methods.rb
@@ -12,9 +12,8 @@ def setup
         end
 
         def test_each
-          attributes = []
-          @xml.xpath("//address")[1].each do |key, value|
-            attributes << [key, value]
+          attributes = @xml.xpath("//address")[1].map do |key, value|
+            [key, value]
           end
           assert_equal([["domestic", "Yes"], ["street", "Yes"]], attributes)
         end

diff --git a/test/xml/test_entity_reference.rb b/test/xml/test_entity_reference.rb
@@ -269,8 +269,7 @@ def setup
           cfg.dtdload
           cfg.noent
         end
-        nodes = []
-        reader.each { |n| nodes << n.value }
+        nodes = reader.map(&:value)
 
         assert_equal ["foobar"], nodes.compact.map(&:strip).reject(&:empty?)
       end
@@ -282,8 +281,7 @@ def setup
           cfg.default_xml
           cfg.dtdload
         end
-        nodes = []
-        reader.each { |n| nodes << n.value }
+        nodes = reader.map(&:value)
 
         assert_empty nodes.compact.map(&:strip).reject(&:empty?)
       end

diff --git a/test/xml/test_unparented_node.rb b/test/xml/test_unparented_node.rb
@@ -83,9 +83,8 @@ def test_keys
       end
 
       def test_each
-        attributes = []
-        @node.xpath(".//address")[1].each do |key, value|
-          attributes << [key, value]
+        attributes = @node.xpath(".//address")[1].map do |key, value|
+          [key, value]
         end
         assert_equal([["domestic", "Yes"], ["street", "Yes"]], attributes)
       end