Skip to content

Commit

Permalink
Merge pull request #2322 from sparklemotion/flavorjones-update-to-min…
Browse files Browse the repository at this point in the history
…i-portile-2.7.0

update to mini portile 2.7.0
  • Loading branch information
flavorjones committed Aug 31, 2021
2 parents d61857d + 35823bd commit b2645bc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Nokogiri follows [Semantic Versioning](https://semver.org/), please see the [REA
### Dependencies

* [CRuby] Vendored libiconv is updated from 1.15 to 1.16. (Note that libiconv is only redistributed in the native windows and native darwin gems, see [`LICENSE-DEPENDENCIES.md`](LICENSE-DEPENDENCIES.md) for more information.) [[#2206](https://github.com/sparklemotion/nokogiri/issues/2206)]
* [CRuby] Upgrade mini_portile2 dependency from `~> 2.6.1` to `~> 2.7.0`. ("ruby" platform gem only.)


### Improved
Expand Down
6 changes: 2 additions & 4 deletions ext/nokogiri/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
REQUIRED_LIBXML_VERSION = "2.6.21"
RECOMMENDED_LIBXML_VERSION = "2.9.3"

# The gem version constraint in the Rakefile is not respected at install time.
# Keep this version in sync with the one in the Rakefile !
REQUIRED_MINI_PORTILE_VERSION = "~> 2.6.1"
REQUIRED_MINI_PORTILE_VERSION = "~> 2.7.0" # keep this version in sync with the one in the gemspec
REQUIRED_PKG_CONFIG_VERSION = "~> 1.1"

# Keep track of what versions of what libraries we build against
Expand Down Expand Up @@ -404,7 +402,7 @@ def iconv_configure_flags

def process_recipe(name, version, static_p, cross_p, cacheable_p=true)
require "rubygems"
gem("mini_portile2", REQUIRED_MINI_PORTILE_VERSION)
gem("mini_portile2", REQUIRED_MINI_PORTILE_VERSION) # gemspec is not respected at install time
require "mini_portile2"
message("Using mini_portile version #{MiniPortile::VERSION}\n")

Expand Down
2 changes: 1 addition & 1 deletion nokogiri.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ Gem::Specification.new do |spec|
spec.rdoc_options = ["--main", "README.md"]

spec.add_runtime_dependency("racc", "~> 1.4")
spec.add_runtime_dependency("mini_portile2", "~> 2.6.1") unless java_p # keep version in sync with extconf.rb
spec.add_runtime_dependency("mini_portile2", "~> 2.7.0") unless java_p # keep version in sync with extconf.rb

spec.add_development_dependency("bundler", "~> 2.2")
spec.add_development_dependency("hoe-markdown", "~> 1.4")
Expand Down

0 comments on commit b2645bc

Please sign in to comment.