Skip to content

Commit

Permalink
Merge pull request #2007 from sparklemotion/flavorjones-cleanup-rakefile
Browse files Browse the repository at this point in the history 
cleanup rakefile
  • Loading branch information
@flavorjones
flavorjones committed Feb 29, 2020
2 parents b8286ae + a265687 commit 9b1d00a
Show file tree
Hide file tree
Showing 7 changed files with 275 additions and 269 deletions.
280 changes: 11 additions & 269 deletions Rakefile
View file
@@ -1,141 +1,21 @@
# -*- ruby -*-
require 'rubygems'
require 'shellwords'
require "rake_compiler_dock"

gem 'hoe'
require 'hoe'

require 'shellwords'
require "rake_compiler_dock"

Hoe.plugin :debugging
Hoe.plugin :git
Hoe.plugin :gemspec
Hoe.plugin :bundler

GENERATED_PARSER = "lib/nokogiri/css/parser.rb"
GENERATED_TOKENIZER = "lib/nokogiri/css/tokenizer.rb"

def java?
/java/ === RUBY_PLATFORM
end

ENV['LANG'] = "en_US.UTF-8" # UBUNTU 10.04, Y U NO DEFAULT TO UTF-8?

CrossRuby = Struct.new(:version, :host) {
def ver
@ver ||= version[/\A[^-]+/]
end

def minor_ver
@minor_ver ||= ver[/\A\d\.\d(?=\.)/]
end

def api_ver_suffix
case minor_ver
when nil
raise "unsupported version: #{ver}"
else
minor_ver.delete('.') << '0'
end
end

def platform
@platform ||=
case host
when /\Ax86_64.*mingw32/
'x64-mingw32'
when /\Ai[3-6]86.*mingw32/
'x86-mingw32'
when /\Ax86_64.*linux/
'x86_64-linux'
when /\Ai[3-6]86.*linux/
'x86-linux'
else
raise "unsupported host: #{host}"
end
end

WINDOWS_PLATFORM_REGEX = /mingw|mswin/
MINGW32_PLATFORM_REGEX = /mingw32/
LINUX_PLATFORM_REGEX = /linux/

def windows?
!!(platform =~ WINDOWS_PLATFORM_REGEX)
end

def tool(name)
(@binutils_prefix ||=
case platform
when 'x64-mingw32'
'x86_64-w64-mingw32-'
when 'x86-mingw32'
'i686-w64-mingw32-'
when 'x86_64-linux'
'x86_64-linux-gnu-'
when 'x86-linux'
'i686-linux-gnu-'
end) + name
end

def target
case platform
when 'x64-mingw32'
'pei-x86-64'
when 'x86-mingw32'
'pei-i386'
end
end

def libruby_dll
case platform
when 'x64-mingw32'
"x64-msvcrt-ruby#{api_ver_suffix}.dll"
when 'x86-mingw32'
"msvcrt-ruby#{api_ver_suffix}.dll"
end
end

def dlls
case platform
when MINGW32_PLATFORM_REGEX
[
'kernel32.dll',
'msvcrt.dll',
'ws2_32.dll',
*(case
when ver >= '2.0.0'
'user32.dll'
end),
libruby_dll,
]
when LINUX_PLATFORM_REGEX
[
'libm.so.6',
*(case
when ver < '2.6.0'
'libpthread.so.0'
end),
'libc.so.6',
]
end
end

def dll_ref_versions
case platform
when LINUX_PLATFORM_REGEX
{"GLIBC"=>"2.17"}
end
end
}

CROSS_RUBIES = File.read('.cross_rubies').lines.flat_map { |line|
case line
when /\A([^#]+):([^#]+)/
CrossRuby.new($1, $2)
else
[]
end
}

ENV['RUBY_CC_VERSION'] ||= CROSS_RUBIES.map(&:ver).uniq.join(":")
require_relative "tasks/util"
require_relative "tasks/cross-ruby"

HOE = Hoe.spec 'nokogiri' do
developer 'Aaron Patterson', 'aaronp@rubyforge.org'
Expand Down Expand Up @@ -165,7 +45,6 @@ HOE = Hoe.spec 'nokogiri' do
'nokogiri.gemspec',
'lib/nokogiri/nokogiri.{bundle,jar,rb,so}',
'lib/nokogiri/[0-9].[0-9]',
'concourse/images/*.generated'
]
self.clean_globs += Dir.glob("ports/*").reject { |d| d =~ %r{/archives$} }

Expand Down Expand Up @@ -203,21 +82,6 @@ end

# ----------------------------------------

def add_file_to_gem relative_source_path
dest_path = File.join(gem_build_path, relative_source_path)
dest_dir = File.dirname(dest_path)

mkdir_p dest_dir unless Dir.exist?(dest_dir)
rm_f dest_path if File.exist?(dest_path)
safe_ln relative_source_path, dest_path

HOE.spec.files << relative_source_path
end

def gem_build_path
File.join 'pkg', HOE.spec.full_name
end

if java?
# TODO: clean this section up.
require "rake/javaextensiontask"
Expand Down Expand Up @@ -279,134 +143,12 @@ Nokogiri is built with the packaged libraries: #{libs}.
end
end

# ----------------------------------------

desc "Generate css/parser.rb and css/tokenizer.rex"
task 'generate' => [GENERATED_PARSER, GENERATED_TOKENIZER]
task 'gem:spec' => 'generate' if Rake::Task.task_defined?("gem:spec")
[:compile, :check_manifest].each do |task_name|
Rake::Task[task_name].prerequisites << GENERATED_PARSER
Rake::Task[task_name].prerequisites << GENERATED_TOKENIZER
end

file GENERATED_PARSER => "lib/nokogiri/css/parser.y" do |t|
sh "racc -l -o #{t.name} #{t.prerequisites.first}"
end

file GENERATED_TOKENIZER => "lib/nokogiri/css/tokenizer.rex" do |t|
sh "rex --independent -o #{t.name} #{t.prerequisites.first}"
end

# ----------------------------------------

desc "set environment variables to build and/or test with debug options"
task :debug do
ENV['NOKOGIRI_DEBUG'] = "true"
ENV['CFLAGS'] ||= ""
ENV['CFLAGS'] += " -DDEBUG"
end

task :java_debug do
ENV['JRUBY_OPTS'] = "#{ENV['JRUBY_OPTS']} --debug --dev"
ENV['JAVA_OPTS'] = '-Xdebug -Xrunjdwp:transport=dt_socket,address=8000,server=y,suspend=y' if ENV['JAVA_DEBUG']
end
Rake::Task[:test].prerequisites << :java_debug

task :rubocop => [:rubocop_security, :rubocop_frozen_string_literals]
task :rubocop_security do
sh "rubocop lib --only Security"
end
task :rubocop_frozen_string_literals do
sh "rubocop lib --auto-correct --only Style/FrozenStringLiteralComment"
end
Rake::Task[:test].prerequisites << :rubocop

if Hoe.plugins.include?(:debugging)
['valgrind', 'valgrind:mem', 'valgrind:mem0'].each do |task_name|
Rake::Task["test:#{task_name}"].prerequisites << :compile
end
end

require 'concourse'
Concourse.new("nokogiri", fly_target: "ci") do |c|
c.add_pipeline "nokogiri", "nokogiri.yml"
c.add_pipeline "nokogiri-pr", "nokogiri-pr.yml"
c.add_pipeline "nokogiri-v1.10.x", "nokogiri-v1.10.x.yml"
end

# ----------------------------------------

def verify_dll(dll, cross_ruby)
dll_imports = cross_ruby.dlls
dump = `#{['env', 'LANG=C', cross_ruby.tool('objdump'), '-p', dll].shelljoin}`
if cross_ruby.windows?
raise "unexpected file format for generated dll #{dll}" unless /file format #{Regexp.quote(cross_ruby.target)}\s/ === dump
raise "export function Init_nokogiri not in dll #{dll}" unless /Table.*\sInit_nokogiri\s/mi === dump

# Verify that the expected DLL dependencies match the actual dependencies
# and that no further dependencies exist.
dll_imports_is = dump.scan(/DLL Name: (.*)$/).map(&:first).map(&:downcase).uniq
if dll_imports_is.sort != dll_imports.sort
raise "unexpected dll imports #{dll_imports_is.inspect} in #{dll}"
end
else
# Verify that the expected so dependencies match the actual dependencies
# and that no further dependencies exist.
dll_imports_is = dump.scan(/NEEDED\s+(.*)/).map(&:first).uniq
if dll_imports_is.sort != dll_imports.sort
raise "unexpected so imports #{dll_imports_is.inspect} in #{dll} (expected #{dll_imports.inspect})"
end

# Verify that the expected so version requirements match the actual dependencies.
dll_ref_versions_list = dump.scan(/0x[\da-f]+ 0x[\da-f]+ \d+ (\w+)_([\d\.]+)$/i)
# Build a hash of library versions like {"LIBUDEV"=>"183", "GLIBC"=>"2.17"}
dll_ref_versions_is = dll_ref_versions_list.each.with_object({}) do |(lib, ver), h|
if !h[lib] || ver.split(".").map(&:to_i).pack("C*") > h[lib].split(".").map(&:to_i).pack("C*")
h[lib] = ver
end
end
if dll_ref_versions_is != cross_ruby.dll_ref_versions
raise "unexpected so version requirements #{dll_ref_versions_is.inspect} in #{dll}"
end
end
puts "#{dll}: Looks good!"
end

CROSS_RUBIES.each do |cross_ruby|
task "tmp/#{cross_ruby.platform}/stage/lib/nokogiri/#{cross_ruby.minor_ver}/nokogiri.so" do |t|
verify_dll t.name, cross_ruby
end
end

namespace "gem" do
CROSS_RUBIES.map(&:platform).uniq.each do |plat|
desc "build native fat binary gems for windows and linux"
multitask "native" => plat

desc "build native gem for #{plat} platform"
task plat do
RakeCompilerDock.sh <<-EOT, platform: plat
gem install bundler &&
bundle &&
rake native:#{plat} pkg/#{HOE.spec.full_name}-#{plat}.gem MAKE='nice make -j`nproc`' RUBY_CC_VERSION=#{ENV['RUBY_CC_VERSION']}
EOT
end
end

desc "build native fat binary gems for windows"
multitask "windows" => CROSS_RUBIES.map(&:platform).uniq.grep(WINDOWS_PLATFORM_REGEX)

desc "build native fat binary gems for linux"
multitask "linux" => CROSS_RUBIES.map(&:platform).uniq.grep(LINUX_PLATFORM_REGEX)

desc "build a jruby gem with docker"
task "jruby" do
RakeCompilerDock.sh "gem install bundler && bundle && rake java gem", rubyvm: 'jruby'
end
end

require_relative "tasks/concourse"
require_relative "tasks/css-generate"
require_relative "tasks/debug"
require_relative "tasks/docker"
require_relative "tasks/set-version-to-timestamp"
require_relative "tasks/docs-linkify"
require_relative "tasks/rubocop"
require_relative "tasks/set-version-to-timestamp"

# vim: syntax=Ruby
7 changes: 7 additions & 0 deletions tasks/concourse.rb
View file
@@ -0,0 +1,7 @@
require "concourse"

Concourse.new("nokogiri", fly_target: "ci") do |c|
c.add_pipeline "nokogiri", "nokogiri.yml"
c.add_pipeline "nokogiri-pr", "nokogiri-pr.yml"
c.add_pipeline "nokogiri-v1.10.x", "nokogiri-v1.10.x.yml"
end

0 comments on commit 9b1d00a

Please sign in to comment.