fix: compiling from source on windows with system libraries

specify ldflags to resolve Nokogiri's symbols.
sparklemotion · Nov 16, 2022 · 15110d6 · 15110d6
1 parent f0bf5d6
commit 15110d6
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/lib/nokogiri/version/info.rb b/lib/nokogiri/version/info.rb
@@ -105,16 +105,16 @@ def to_hash
             if libxml2_using_packaged?
               cppflags << "-I#{File.join(header_directory, "include").shellescape}"
               cppflags << "-I#{File.join(header_directory, "include/libxml2").shellescape}"
+            end
 
-              if windows?
-                # on windows, nokogumbo needs to link against nokogiri.so to resolve symbols. see #2167
-                lib_directory = File.expand_path(File.join(File.dirname(__FILE__), "../#{ruby_minor}"))
-                unless File.exist?(lib_directory)
-                  lib_directory = File.expand_path(File.join(File.dirname(__FILE__), ".."))
-                end
-                ldflags << "-L#{lib_directory.shellescape}"
-                ldflags << "-l:nokogiri.so"
+            if windows?
+              # on windows, nokogumbo needs to link against nokogiri.so to resolve symbols. see #2167
+              lib_directory = File.expand_path(File.join(File.dirname(__FILE__), "../#{ruby_minor}"))
+              unless File.exist?(lib_directory)
+                lib_directory = File.expand_path(File.join(File.dirname(__FILE__), ".."))
               end
+              ldflags << "-L#{lib_directory.shellescape}"
+              ldflags << "-l:nokogiri.so"
             end
 
             nokogiri["cppflags"] = cppflags