Merge pull request #610 from sparklemotion/flavorjones-drop-force-enc…

…oding fix: stop force_encoding the page body
sparklemotion · Apr 7, 2023 · 18ca167 · 18ca167
2 parents 4c8d3d2 + 96a28e7
commit 18ca167
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/mechanize/page.rb b/lib/mechanize/page.rb
@@ -41,10 +41,6 @@ def initialize(uri=nil, response=nil, body=nil, code=nil, mech=nil)
     @encodings.concat self.class.response_header_charset(response)
 
     if body
-      # Force the encoding to be 8BIT so we can perform regular expressions.
-      # We'll set it to the detected encoding later
-      body.force_encoding(Encoding::ASCII_8BIT)
-
       @encodings.concat self.class.meta_charset body
 
       meta_content_type = self.class.meta_content_type body

diff --git a/test/test_mechanize_page.rb b/test/test_mechanize_page.rb
@@ -276,5 +276,19 @@ def test_multiple_titles
 		assert_equal page.title, "HTML>TITLE"
 	end
 
+  def test_frozen_string_body
+    html = (<<~HTML).freeze
+      <html>
+        <head>
+          <title>Page Title</title>
+        </head>
+        <body>
+          <p>Hello World</p>
+        </body>
+      </html>
+    HTML
+
+    html_page(html) # refute_raises
+  end
 end