Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spark-react test errors by adding react component proptype #2237

Merged

Conversation

afebbraro
Copy link
Contributor

@afebbraro afebbraro commented Oct 28, 2019

What does this PR do?

We have been getting react test errors/warnings since the new docs site started. See below screenshot. I fixed this by researching and discovering a newer proptype that we should use going forward when we have a prop that can be of type react component. I left the old proptype values and added the new one. Leaving the old ones for now ensures that we don't have a breaking change. see: …facebook/prop-types#211 for more info
Screen Shot 2019-10-28 at 8 27 55 AM

Associated Issue

Fixes #2238
This involves our react package and will be good to update that in the release notes when we launch that we added an additional proptype option of PropTypes.elementType to SprkLinks (element), SprkCardTeaser (ctaLinkElement, mediaLinkElement) and SprkMasthead (logoLinkElement).

Please check off completed items as you work.

If a checklist item or section does not apply to your PR
then please remove it.

Documentation

  • No documentation changes needed because proptype documentation in react is autogenerated in the SB apart of NDS and these changes are apart of that.

Code

  • Build Component in Spark React
  • Unit Testing in Spark React with gulp test-react (100% coverage, 100% passing)

Accessibility

Browser Testing (current version and 1 prior)

  • Google Chrome
  • Google Chrome (Mobile)
  • Mozilla Firefox
  • Mozilla Firefox (Mobile)
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari
  • Apple Safari (Mobile)

@afebbraro afebbraro added the status: PR review Use this when a PR is ready for review label Oct 28, 2019
@afebbraro afebbraro merged commit 24586a2 into sparkdesignsystem:mono-split Oct 28, 2019
@ssabo1 ssabo1 added this to the 10.21.19-11.1.19 milestone Oct 28, 2019
@afebbraro afebbraro deleted the react-test-error-fixes branch February 15, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: PR review Use this when a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants