py-pod5: Init at 0.3.10 #44100
Open
py-pod5: Init at 0.3.10 #44100
+259
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandapip1
force-pushed
the
add-pod5
branch
4 times, most recently
from
762c371
to
e221402
Compare
Pandapip1
force-pushed
the
add-pod5
branch
2 times, most recently
from
1a72288
to
399bd8f
Compare
alalazo
requested changes
May 17, 2024
|
|
||
| license("MPL-2.0", checked_by="Pandapip1") | ||
|
|
||
| if (arch == "x86_64" or arch == "x64") and os == "linux": # Linux on x86_64 |
There was a problem hiding this comment.
We should build from source, using CMake. Any advice @adamjstewart ?
There was a problem hiding this comment.
Yes, we should download from GitHub, set the build_directory to python/lib_pod5, and try the normal PythonPackage base class. If that doesn't work, we may need to build with CMakePackage or depend on a new C++ package in addition to the Python package. Don't have time to help myself, but see https://spack.readthedocs.io/en/latest/build_systems/pythonpackage.html for the docs on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
py-pod5, a command line utility for the POD5 file format.Blocked by #44190