Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-jsonschema: add v4.18.6 -> v4.22.0 #44025

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tristan0x
Copy link
Contributor

This change adds the latest minor versions of py-jsonschema since 4.17, and removes 3.0.1 to benefit 3.0.2. This change also updates the GitHub homepage of the project.

Copy link

spackbot-app bot commented May 6, 2024

Hi @tristan0x! I noticed that the following package(s) don't yet have maintainers:

  • py-jsonschema

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("tristan0x")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-jsonschema

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@tristan0x tristan0x marked this pull request as ready for review May 6, 2024 08:07
tristan0x added a commit to BlueBrain/spack that referenced this pull request May 6, 2024
…hema

Change in py-jsonschema has been upstreamed already: spack#44025
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the homepage and new version sha256s.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have guidelines on when to deprecate (versus remove) old versions. Is "temporarily" deprecating (https://spack.readthedocs.io/en/latest/packaging_guide.html#deprecating-old-versions) 3.0.1 a suitable alternative?

@tldahlgren tldahlgren self-assigned this May 6, 2024
@tristan0x
Copy link
Contributor Author

Thank you very @tldahlgren for your review.

We have guidelines on when to deprecate (versus remove) old versions. Is "temporarily" deprecating (https://spack.readthedocs.io/en/latest/packaging_guide.html#deprecating-old-versions) 3.0.1 a suitable alternative?

I don't have the expertise to decide whether 3.0.1 should be removed. I reverted this change in d951b4f

Thank you

@tldahlgren
Copy link
Contributor

Not sure why flux-sched is affecting CI.

@tldahlgren tldahlgren closed this May 7, 2024
@tldahlgren tldahlgren reopened this May 7, 2024
@tldahlgren
Copy link
Contributor

🤦

@spackbot run pipeline

Copy link

spackbot-app bot commented May 7, 2024

I've started that pipeline for you!

@tristan0x
Copy link
Contributor Author

Not sure why flux-sched is affecting CI.

The CMake phase of package flux-sched finds py-jsonschema but seems unable to extract its version https://gitlab.spack.io/spack/spack/-/jobs/11204452#L674

I will try to reproduce the issue later on.

@alecbcs alecbcs changed the title py-jsonschema: add versions py-jsonschema: add v4.18.6 -> v4.22.0 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants