New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py-jsonschema: add v4.18.6 -> v4.22.0 #44025
base: develop
Are you sure you want to change the base?
Conversation
Hi @tristan0x! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("tristan0x") If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame py-jsonschema Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
…hema Change in py-jsonschema has been upstreamed already: spack#44025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the homepage and new version sha256s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have guidelines on when to deprecate (versus remove) old versions. Is "temporarily" deprecating (https://spack.readthedocs.io/en/latest/packaging_guide.html#deprecating-old-versions) 3.0.1
a suitable alternative?
Thank you very @tldahlgren for your review.
I don't have the expertise to decide whether 3.0.1 should be removed. I reverted this change in d951b4f Thank you |
Not sure why |
🤦 @spackbot run pipeline |
I've started that pipeline for you! |
The CMake phase of package I will try to reproduce the issue later on. |
This change adds the latest minor versions of py-jsonschema since 4.17, and removes 3.0.1 to benefit 3.0.2. This change also updates the GitHub homepage of the project.