py-cryptography: does not run-depend on py-setuptools-rust #39386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
previously approved these changes
Aug 11, 2023
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
wdconinc
commented
Aug 11, 2023
adamjstewart
approved these changes
Aug 11, 2023
mpokorny
pushed a commit
to mpokorny/spack
that referenced
this pull request
Sep 18, 2023
* py-cryptography: does not run-depend on py-setuptools-rust * py-cryptography: depens_on py-setuptools-rust when @3.4.2: Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com> * py-cryptography: re-add depends_on type=run for narrow range --------- Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 3.4.2, pyca/cryptography#5779 and backport pyca/cryptography#5781, py-cryptography does not have a runtime dependency on py-setuptools-rust anymore, only a build dependency. Version 3.4.1 is the last version with
install_requires=setup_requirements. Since the older versions after 3.4 but before 3.4.2 are not in spack, no specific exception is added to require the runtime dependency for 3.4:3.4.1.(Yay, rust is garbage collected away again.)