Pin pytest<=5.3.5 because --basetemp is broken #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rendinam
approved these changes
Mar 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #4748 +/- ##
=======================================
Coverage 52.57% 52.57%
=======================================
Files 400 400
Lines 34936 34936
Branches 5414 5414
=======================================
Hits 18369 18369
Misses 15456 15456
Partials 1111 1111
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest version of Pytest
5.4.1broke--basetempwhen used in conjunction withpytest-xdist.See pytest-dev/pytest#6987
This PR pins it for now. This will fix the issue of failed test artifacts not being pushed to Artifactory (and thus tests not being able to be OKified).