rename extra.css to custom.css to bust cache #390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The recent banner CSS fix revealed the issue we are having with custom css assets. For some reason, MKDocs doesn't provide a out-of-the-box way of cache busting for these assets by appending unique hash string to the file name, for example.
I've also found the open issue: mkdocs/mkdocs#1979
As a hotfix, let's rename
extra.css
tocustom.css
and afterwards will think of a long-term solution.Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:
main
branch.If the proposed change is ready to be merged, please request a review from
@spacelift-io/solutions-engineering
. Someone will review and merge the pull request.Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 馃檱