Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename extra.css to custom.css to bust cache #390

Merged
merged 1 commit into from Nov 28, 2023
Merged

Conversation

Roma36
Copy link
Contributor

@Roma36 Roma36 commented Nov 28, 2023

Description of the change

The recent banner CSS fix revealed the issue we are having with custom css assets. For some reason, MKDocs doesn't provide a out-of-the-box way of cache busting for these assets by appending unique hash string to the file name, for example.

I've also found the open issue: mkdocs/mkdocs#1979

As a hotfix, let's rename extra.css to custom.css and afterwards will think of a long-term solution.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 馃檱

@Roma36 Roma36 requested review from jmfontaine and a team November 28, 2023 09:52
Copy link

render bot commented Nov 28, 2023

@Roma36 Roma36 changed the title rename extrac.css to custom.css to bust cache rename extra.css to custom.css to bust cache Nov 28, 2023
@Roma36 Roma36 merged commit 5931acb into main Nov 28, 2023
1 check passed
@Roma36 Roma36 deleted the hotfix-custom-css-cache branch November 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants