Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe removal #1488

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Unsafe removal #1488

wants to merge 7 commits into from

Commits on Nov 11, 2023

  1. fix: replaced equivalent unsafes with safe alternatives

    @Wicpar
    Wicpar committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    7189e2b View commit details
    Browse the repository at this point in the history

  2. fix: replaced equivalent unsafes with safe alternatives

    @Wicpar
    Wicpar committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    711045a View commit details
    Browse the repository at this point in the history

  3. fix: removed fastcmp because it is 11 instructions and two jumps long… 

    …er than the default cmp
    @Wicpar
    Wicpar committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    eaefbd7 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. fix(benchmarks): fixed criterion benchmark not compiling on windows d… 

    …ue to jemalloc

(cherry picked from commit 2c2d9b3)
    @Wicpar
    Wicpar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    45a1e77 View commit details
    Browse the repository at this point in the history

  2. removed unsafes in iobuf, cleaned code a bit.

    @Wicpar
    Wicpar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    272e8ee View commit details
    Browse the repository at this point in the history

  3. removed unsound static lifetime slice returned in iobuf

    @Wicpar
    Wicpar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    8fa4a95 View commit details
    Browse the repository at this point in the history

  4. added unchecked unwraps on io buf access for ~3% perf increase

    @Wicpar
    Wicpar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    ea9c0df View commit details
    Browse the repository at this point in the history