Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXP: integrate pre-commit.ci fixes, except for tox.ini updates #3149

Open
wants to merge 17 commits into
base: latest
Choose a base branch
from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented May 7, 2024

The pre-commit.ci autoupdate PR #3003 makes a bunch of minor changes, all of which are fine, except for the updates to tox.ini which break with this error: tox-dev/tox-conda#108

(I can replicate this error on my laptop, too, in a clean mamba environment.)

Rather than debug the tox.ini changes, I am using this PR to revert the breakage and commit the rest. We shall see!

pre-commit-ci bot and others added 11 commits March 12, 2024 23:31
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/astral-sh/ruff-pre-commit: v0.2.0 → v0.3.2](astral-sh/ruff-pre-commit@v0.2.0...v0.3.2)
- [github.com/tox-dev/tox-ini-fmt: 0.5.2 → 1.3.1](tox-dev/tox-ini-fmt@0.5.2...1.3.1)
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.4.0...v4.6.0)
- [github.com/astral-sh/ruff-pre-commit: v0.2.0 → v0.4.3](astral-sh/ruff-pre-commit@v0.2.0...v0.4.3)
- [github.com/tox-dev/tox-ini-fmt: 0.5.2 → 1.3.1](tox-dev/tox-ini-fmt@0.5.2...1.3.1)
@ctb
Copy link
Contributor Author

ctb commented May 7, 2024

note, tests pass on my laptop: tox -e py310

@ctb
Copy link
Contributor Author

ctb commented May 7, 2024

and 😭 the pre-commit hooks auto-update tox.ini. So.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.62%. Comparing base (4acae1c) to head (b9efea3).
Report is 1 commits behind head on latest.

Files Patch % Lines
src/sourmash/sbt.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3149   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files         136      136           
  Lines       15819    15819           
  Branches     2713     2713           
=======================================
  Hits        13703    13703           
  Misses       1806     1806           
  Partials      310      310           
Flag Coverage Δ
hypothesis-py 25.36% <0.00%> (ø)
python 92.32% <80.00%> (ø)
rust 61.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb ctb changed the title MRG: integrate pre-commit.ci fixes, except for tox.ini updates EXP: integrate pre-commit.ci fixes, except for tox.ini updates May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant