Fallback to :response_body if :body is not set (faraday 1.0 support) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraday 0.16.x changed the key names, this should allow us to support both 0.15.x and 0.16.x for now
|
Hello, @CGA1123! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
bunny-cyber
approved these changes
Mar 17, 2020
CGA1123
changed the title
|
Hey @lucasmazza @tegon not sure who is maintaining this now but you are the most recent mergers 😄 It would be quite nice to have this merged in to allow support for |
2 tasks
|
Thanks @CGA1123! I've merged it and hope to release a new version supporting Faraday 1.0.x soon. |
|
@georgeguimaraes Thanks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faraday 0.16.x changed the key names, this should allow us to support(reverted in 0.17.x)both 0.15.x and 0.16.x for now.
Adds backwards-compatible support for Faraday 1.0.
Other alternatives to fix are to remove the call to
.to_hashand access directly with#[], or to call#body.The prefered solution appears to be to use
#body. However, there is some benefit in being explicit I suppose - please let me know what you would prefer.Closes: #114
Related: lostisland/faraday#847
Edit: Updated for
faraday-1.0.0