release(executors): update ami naming #62579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BolajiOlajide
changed the title
burmudar
reviewed
May 9, 2024
| @@ -25,7 +25,7 @@ export AWS_SECRET_ACCESS_KEY="${AWS_EXECUTOR_AMI_SECRET_KEY}" | |||
|
|
|||
| # Point to GCP boot disk image/AMI built by //cmd/executor/vm-image:ami.build | |||
| NAME="${IMAGE_FAMILY}" | |||
| if [ "${RELEASE_INTERNAL:-}" != "true" ]; then | |||
| if [ "${RELEASE_INTERNAL:-}" == "true" ]; then | |||
There was a problem hiding this comment.
Need a similar one for docker mirror?
There was a problem hiding this comment.
Hmmm does ami.push only get triggered during releases?
There was a problem hiding this comment.
I was going to ask that, I assumed it is but not 100% certain.
We can revisit this PR next week when everyone is back btw.
There was a problem hiding this comment.
BolajiOlajide
force-pushed
the
bo/update-ami-naming
branch
from
d03bc32
to
1652b48
Compare
BolajiOlajide
added
the
backport 5.4.0
burmudar
approved these changes
May 14, 2024
BolajiOlajide
removed
the
backport 5.4.0
BolajiOlajide
added
the
backport 5.4.0
sourcegraph-release-guild-bot
pushed a commit
that referenced
this pull request
May 14, 2024
* update naming * update docker mirror image family name (cherry picked from commit 894a951)
BolajiOlajide
added a commit
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Test plan
We found out during the 5.4.0 release that the amis weren't named properly. Thus PR fixes that.
Below is the matrix for naming AMIs.
Matrix