New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appliance: deploy syntect-server #62570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfurman
commented
May 9, 2024
@@ -0,0 +1,222 @@ | |||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output of:
go run ./internal/appliance/dev/compare-helm \
-component syntect-server \
-golden-file internal/appliance/testdata/golden-fixtures/syntect/default.yaml \
-helm-template-extra-args '--set syntect.serviceAccount.create=true'
I don't see anything that stands out, please give it a look if reviewing though:
2c2
< # helm: Service/syntect-server
---
> # golden: Service/syntect-server
6a7
> appliance.sourcegraph.com/configHash: 9ede95ea4e7966c44b553ccf3bb3edbb1e4811c9a554051f842b643a6c5e63e2
8a10
> creationTimestamp: "2024-04-19T00:00:00Z"
13a16,25
> namespace: NORMALIZED_FOR_TESTING
> ownerReferences:
> - apiVersion: v1
> blockOwnerDeletion: true
> controller: true
> kind: ConfigMap
> name: sg
> uid: NORMALIZED_FOR_TESTING
> resourceVersion: NORMALIZED_FOR_TESTING
> uid: NORMALIZED_FOR_TESTING
14a27,33
> clusterIP: NORMALIZED_FOR_TESTING
> clusterIPs:
> - NORMALIZED_FOR_TESTING
> internalTrafficPolicy: Cluster
> ipFamilies:
> - IPv4
> ipFamilyPolicy: SingleStack
17a37
> protocol: TCP
21,22c41
< app.kubernetes.io/instance: release-name
< app.kubernetes.io/name: sourcegraph
---
> sessionAffinity: None
23a43,44
> status:
> loadBalancer: {}
25c46
< # helm: Deployment/syntect-server
---
> # golden: Deployment/syntect-server
30c51,53
< description: Backend for syntax highlighting operations.
---
> appliance.sourcegraph.com/configHash: 9ede95ea4e7966c44b553ccf3bb3edbb1e4811c9a554051f842b643a6c5e63e2
> creationTimestamp: "2024-04-19T00:00:00Z"
> generation: 1
33,34d55
< app.kubernetes.io/instance: release-name
< app.kubernetes.io/managed-by: Helm
36c57
< app.kubernetes.io/version: 5.3.2
---
> app.kubernetes.io/version: 5.3.9104
38d58
< helm.sh/chart: sourcegraph-5.3.2
39a60,69
> namespace: NORMALIZED_FOR_TESTING
> ownerReferences:
> - apiVersion: v1
> blockOwnerDeletion: true
> controller: true
> kind: ConfigMap
> name: sg
> uid: NORMALIZED_FOR_TESTING
> resourceVersion: NORMALIZED_FOR_TESTING
> uid: NORMALIZED_FOR_TESTING
41a72
> progressDeadlineSeconds: 600
47,48d77
< app.kubernetes.io/instance: release-name
< app.kubernetes.io/name: sourcegraph
57a87
> creationTimestamp: null
60,61d89
< app.kubernetes.io/instance: release-name
< app.kubernetes.io/name: sourcegraph
62a91
> name: syntect-server
64d92
< affinity: null
66,67c94
< - env: null
< image: index.docker.io/sourcegraph/syntax-highlighter:5.3.2@sha256:3d16ab2a0203fea85063dcfe2e9d476540ef3274c28881dc4bbd5ca77933d8e8
---
> - image: index.docker.io/sourcegraph/syntax-highlighter:5.3.2@sha256:3d16ab2a0203fea85063dcfe2e9d476540ef3274c28881dc4bbd5ca77933d8e8
69a97
> failureThreshold: 3
74a103,104
> periodSeconds: 10
> successThreshold: 1
79a110
> protocol: TCP
80a112,114
> failureThreshold: 3
> periodSeconds: 10
> successThreshold: 1
82a117
> timeoutSeconds: 1
94a130
> terminationMessagePath: /dev/termination-log
96,100c132,229
< volumeMounts: null
< nodeSelector: null
< securityContext: {}
< tolerations: null
< volumes: null
---
> dnsPolicy: ClusterFirst
> restartPolicy: Always
> schedulerName: default-scheduler
> securityContext:
> fsGroup: 101
> fsGroupChangePolicy: OnRootMismatch
> runAsGroup: 101
> runAsUser: 100
> terminationGracePeriodSeconds: 30
> status: {}
> ---
> # golden: ConfigMap/sg
> apiVersion: v1
> data:
> spec: |
> spec:
> requestedVersion: "5.3.9104"
>
> blobstore:
> disabled: true
>
> codeInsights:
> disabled: true
>
> codeIntel:
> disabled: true
>
> frontend:
> disabled: true
>
> gitServer:
> disabled: true
>
> indexedSearch:
> disabled: true
>
> indexedSearchIndexer:
> disabled: true
>
> pgsql:
> disabled: true
>
> postgresExporter:
> disabled: true
>
> preciseCodeIntel:
> disabled: true
>
> redisCache:
> disabled: true
>
> redisStore:
> disabled: true
>
> repoUpdater:
> disabled: true
>
> searcher:
> disabled: true
>
> symbols:
> disabled: true
>
> syntectServer: {}
>
> worker:
> disabled: true
> kind: ConfigMap
> metadata:
> annotations:
> appliance.sourcegraph.com/currentVersion: 5.3.9104
> appliance.sourcegraph.com/managed: "true"
> creationTimestamp: "2024-04-19T00:00:00Z"
> name: sg
> namespace: NORMALIZED_FOR_TESTING
> resourceVersion: NORMALIZED_FOR_TESTING
> uid: NORMALIZED_FOR_TESTING
> ---
> # golden: ServiceAccount/syntect-server
> apiVersion: v1
> kind: ServiceAccount
> metadata:
> annotations:
> appliance.sourcegraph.com/configHash: 9ede95ea4e7966c44b553ccf3bb3edbb1e4811c9a554051f842b643a6c5e63e2
> creationTimestamp: "2024-04-19T00:00:00Z"
> labels:
> deploy: sourcegraph
> name: syntect-server
> namespace: NORMALIZED_FOR_TESTING
> ownerReferences:
> - apiVersion: v1
> blockOwnerDeletion: true
> controller: true
> kind: ConfigMap
> name: sg
> uid: NORMALIZED_FOR_TESTING
> resourceVersion: NORMALIZED_FOR_TESTING
> uid: NORMALIZED_FOR_TESTING
jdpleiness
approved these changes
May 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing stands out to me either, looks good 🚀
craigfurman
force-pushed
the
appliance-syntect
branch
from
May 13, 2024 08:21
2b700f8
to
21178f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reasonably simple one, I think!
Closes https://github.com/sourcegraph/sourcegraph-operator/issues/40
Test plan
Golden tests included.