rockskip: ruler function is just bits.TrailingZeros #62567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't help but make this change after seeing the algorithm. Feel free to just close this if this makes it less clear, but this kinda feels clearer in my head but I am probably weird. Test Plan: TestRuler passes
github-actions
bot
added
team/product-platform
team/search-platform
jtibshirani
approved these changes
May 9, 2024
|
@jtibshirani updated with a comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't help but make this change after seeing the algorithm in #62510. Feel free to just close this if this makes it less clear, but this kinda feels clearer in my head but I am probably weird.
Test Plan: TestRuler passes