WIP: Refine type for ClosestUploads #62528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upload filtering code previously did a check whether: - The commit corresponding to the upload actually existing on gitserver - The path of interest had an associated SCIP document in that upload. However, the second code path incorrectly only handled the case when the first operation was a no-op. In case some uploads were filtered out due to the path existing (or not) in the wrong upload, and the final result could still have uploads for which the commit no longer existed on gitserver.
github-actions
bot
added
team/graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an invariant in the implementation for closest uploads which
is not documented in the function signature. This makes it hard to reason
about which uploads can be returned. This attempts to document that
invariant using types rather than just a comment.
Unfortunately, the OrderedMap type here doesn't expose an API
which allows arbitrary indexing, making it hard to use as a drop-in replacement.
We should probably introduce a collections.MonotonicOrderedMap for that.
Test plan
Existing tests should pass.