release(upgradetest): confirm postrelease version is newer than the latest sourcegraph version #62463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BolajiOlajide
commented
May 6, 2024
| if latestFullVer == nil || tag.GreaterThan(latestFullVer) { | ||
| latestFullVer = tag | ||
| if latestFullVer == nil || v.GreaterThan(latestFullVer) { | ||
| latestFullVer = v | ||
| } | ||
| latestMinorVer, err = semver.NewVersion(fmt.Sprintf("%d.%d.0", latestFullVer.Major(), latestFullVer.Minor())) | ||
| if err != nil { | ||
| return nil, nil, nil, nil, nil, nil, err | ||
| } | ||
| } |
There was a problem hiding this comment.
@DaedalusG I took the liberty of tweaking the logic here as I don't think we need the second loop here. Moving this logic after appending to validTags will achieve the same result albeit faster.
Let me know if you have concerns
DaedalusG
reviewed
May 6, 2024
| } | ||
| latestMinorVer, err = semver.NewVersion(fmt.Sprintf("%d.%d.0", latestFullVer.Major(), latestFullVer.Minor())) | ||
| if err != nil { | ||
| return nil, nil, nil, nil, nil, nil, err | ||
| } | ||
| } | ||
|
|
||
| semverPostRelease := semver.MustParse(postRelease) |
There was a problem hiding this comment.
We should probably wrap this in a check to make sure the postRelease flag is set. There are ways to run this test without specifying postRelease targets
There was a problem hiding this comment.
Oh I see. Added an if check to only do this is the postRelease flag is set.
There was a problem hiding this comment.
@DaedalusG Can you re-review when you have some time?
DaedalusG
approved these changes
May 13, 2024
BolajiOlajide
added
the
backport 5.4.0
BolajiOlajide
added a commit
that referenced
this pull request
May 14, 2024
… newer than the latest sourcegraph version (#62651) release(upgradetest): confirm postrelease version is newer than the latest sourcegraph version (#62463) * check for post release version * check if postRelease is provided (cherry picked from commit c1e29f0) Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week, I ran into an obscure error where an internal release build had it's release tests failing.
Context
This led to an hypothesis where we believe the version I was trying to release
5.3.666was assumed by the tests to be behind the latest version5.3.12303. I added this check to ensure this doesn't repeat itself.Test plan
Will test during the release testing later.