Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix invalid dates for go 1.13 modules #5492

Merged
merged 3 commits into from Sep 6, 2019
Merged

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented Sep 6, 2019

Go 1.13 now performs additional verification on version strings in go.mod files. It seems like some of our dependencies (and transitive dependencies) have malformed timestamps. I am not sure how this occurred.

According to https://golang.org/doc/go1.13#version-validation, the solution is to replace those malformed version strings with just a commit hash. This PR is the result of me doing so along with running go mod tidy afterwards.

See:

@nicksnyder nicksnyder self-requested a review September 6, 2019 21:24
@ggilmore
Copy link
Contributor Author

ggilmore commented Sep 6, 2019

CI is failing because the db-backcompat test is running against an old commit that uses the invalid version strings. I'll add a dummy migration to bypass this.

@ggilmore
Copy link
Contributor Author

ggilmore commented Sep 6, 2019

@nicksnyder PTAL

@ggilmore ggilmore merged commit b144001 into master Sep 6, 2019
@ggilmore ggilmore deleted the fix-1.13-timestamps branch September 6, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants