New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: upgrade prettier to the latest version to support TS satisfies
operator
#45400
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits a1bd503 and 3a774ed or learn more. Open explanation
|
@@ -489,7 +489,6 @@ | |||
"cssnano": "4.1.10", | |||
"webpack": "5", | |||
"tslib": "2.1.0", | |||
"prettier": "2.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version was pinned in the Storybook upgrade PR, so it's safe to unpin it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see
Codenotify: Notifying subscribers in CODENOTIFY files for diff 3a774ed...a1bd503.
|
Codenotify: Notifying subscribers in OWNERS files for diff 3a774ed...a1bd503.
|
@@ -489,7 +489,7 @@ | |||
"cssnano": "4.1.10", | |||
"webpack": "5", | |||
"tslib": "2.1.0", | |||
"prettier": "2.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wat why did we pin it to 2.2 but the package json says 2.7 👀
@@ -489,7 +489,6 @@ | |||
"cssnano": "4.1.10", | |||
"webpack": "5", | |||
"tslib": "2.1.0", | |||
"prettier": "2.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see
Context
TypeScript 4.9 Beta has been released and we are on it already. But our current
prettier
version doesn't support the new satisfies operator. This PR upgradesprettier
to fix this issue.See related GitHub issue:
Reviewers
yarn format
changes are extracted into a separate commit. Reviewable changes are in the other two commits: 1, 2.Test plan
CI is green.
App preview:
Check out the client app preview documentation to learn more.