Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: upgrade prettier to the latest version to support TS satisfies operator #45400

Merged
merged 3 commits into from Dec 8, 2022

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov commented Dec 8, 2022

Context

TypeScript 4.9 Beta has been released and we are on it already. But our current prettier version doesn't support the new satisfies operator. This PR upgrades prettier to fix this issue.

See related GitHub issue:

Reviewers

yarn format changes are extracted into a separate commit. Reviewable changes are in the other two commits: 1, 2.

Test plan

CI is green.

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot bot added the cla-signed label Dec 8, 2022
@valerybugakov valerybugakov self-assigned this Dec 8, 2022
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Dec 8, 2022
@sg-e2e-regression-test-bob
Copy link

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.09 kb) 0.00% (+0.09 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits a1bd503 and 3a774ed or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@@ -489,7 +489,6 @@
"cssnano": "4.1.10",
"webpack": "5",
"tslib": "2.1.0",
"prettier": "2.8.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version was pinned in the Storybook upgrade PR, so it's safe to unpin it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see

@valerybugakov valerybugakov marked this pull request as ready for review December 8, 2022 10:04
@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 3a774ed...a1bd503.

Notify File(s)
@courier-new client/web/src/enterprise/batches/BatchSpec.tsx
client/web/src/enterprise/batches/MultiSelectContext.tsx
client/web/src/enterprise/batches/backend.ts
client/web/src/enterprise/batches/batch-spec/BatchSpecContext.tsx
client/web/src/enterprise/batches/batch-spec/batch-spec.mock.ts
client/web/src/enterprise/batches/batch-spec/edit/editor/MonacoBatchSpecEditor.tsx
client/web/src/enterprise/batches/batch-spec/edit/workspaces-preview/WorkspacesPreview.tsx
client/web/src/enterprise/batches/batch-spec/execute/ExecuteBatchSpecPage.story.tsx
client/web/src/enterprise/batches/batch-spec/execute/ExecuteBatchSpecPage.tsx
client/web/src/enterprise/batches/batch-spec/execute/workspaces/ExecutionWorkspaces.tsx
client/web/src/enterprise/batches/close/BatchChangeCloseChangesetsList.tsx
client/web/src/enterprise/batches/close/BatchChangeClosePage.tsx
client/web/src/enterprise/batches/detail/BatchChangeBurndownChart.tsx
client/web/src/enterprise/batches/detail/BatchChangeDetailsPage.tsx
client/web/src/enterprise/batches/detail/BatchChangeDetailsTabs.tsx
client/web/src/enterprise/batches/detail/changesets/BatchChangeChangesets.tsx
client/web/src/enterprise/batches/detail/changesets/ChangesetFileDiff.tsx
client/web/src/enterprise/batches/detail/changesets/ChangesetSelectRow.story.tsx
client/web/src/enterprise/batches/detail/changesets/ExternalChangesetInfoCell.tsx
client/web/src/enterprise/batches/list/BatchChangeNode.tsx
client/web/src/enterprise/batches/list/BatchChangeStatsBar.tsx
client/web/src/enterprise/batches/preview/BatchChangePreviewStatsBar.tsx
client/web/src/enterprise/batches/preview/list/PreviewList.tsx
client/web/src/enterprise/batches/preview/list/PreviewSelectRow.tsx
client/web/src/enterprise/batches/preview/utils.ts
client/web/src/enterprise/batches/repo/BatchChangeRepoPage.story.tsx
client/web/src/enterprise/batches/useBatchChangesLicense.ts
client/web/src/enterprise/batches/workspaces-list/ListItem.story.tsx
@efritz client/web/src/enterprise/codeintel/badge/components/RequestLink.tsx
client/web/src/enterprise/codeintel/badge/hooks/useCodeIntelStatus.ts
client/web/src/enterprise/codeintel/configuration/components/BranchTargetSettings.tsx
client/web/src/enterprise/codeintel/configuration/components/GitObjectPreview.tsx
client/web/src/enterprise/codeintel/configuration/components/IndexSettings.tsx
client/web/src/enterprise/codeintel/configuration/components/RepositoryPreview.tsx
client/web/src/enterprise/codeintel/configuration/components/RetentionSettings.tsx
client/web/src/enterprise/codeintel/configuration/hooks/useSavePolicyConfiguration.tsx
client/web/src/enterprise/codeintel/configuration/hooks/useUpdateInferenceScript.tsx
client/web/src/enterprise/codeintel/configuration/pages/CodeIntelRepositoryIndexConfigurationPage.tsx
client/web/src/enterprise/codeintel/indexes/pages/CodeIntelIndexPage.tsx
client/web/src/enterprise/codeintel/uploads/pages/CodeIntelUploadPage.tsx
client/web/src/enterprise/codeintel/uploads/pages/CodeIntelUploadsPage.tsx
@eseliger client/web/src/enterprise/batches/BatchSpec.tsx
client/web/src/enterprise/batches/MultiSelectContext.tsx
client/web/src/enterprise/batches/backend.ts
client/web/src/enterprise/batches/batch-spec/BatchSpecContext.tsx
client/web/src/enterprise/batches/batch-spec/batch-spec.mock.ts
client/web/src/enterprise/batches/batch-spec/edit/editor/MonacoBatchSpecEditor.tsx
client/web/src/enterprise/batches/batch-spec/edit/workspaces-preview/WorkspacesPreview.tsx
client/web/src/enterprise/batches/batch-spec/execute/ExecuteBatchSpecPage.story.tsx
client/web/src/enterprise/batches/batch-spec/execute/ExecuteBatchSpecPage.tsx
client/web/src/enterprise/batches/batch-spec/execute/workspaces/ExecutionWorkspaces.tsx
client/web/src/enterprise/batches/close/BatchChangeCloseChangesetsList.tsx
client/web/src/enterprise/batches/close/BatchChangeClosePage.tsx
client/web/src/enterprise/batches/detail/BatchChangeBurndownChart.tsx
client/web/src/enterprise/batches/detail/BatchChangeDetailsPage.tsx
client/web/src/enterprise/batches/detail/BatchChangeDetailsTabs.tsx
client/web/src/enterprise/batches/detail/changesets/BatchChangeChangesets.tsx
client/web/src/enterprise/batches/detail/changesets/ChangesetFileDiff.tsx
client/web/src/enterprise/batches/detail/changesets/ChangesetSelectRow.story.tsx
client/web/src/enterprise/batches/detail/changesets/ExternalChangesetInfoCell.tsx
client/web/src/enterprise/batches/list/BatchChangeNode.tsx
client/web/src/enterprise/batches/list/BatchChangeStatsBar.tsx
client/web/src/enterprise/batches/preview/BatchChangePreviewStatsBar.tsx
client/web/src/enterprise/batches/preview/list/PreviewList.tsx
client/web/src/enterprise/batches/preview/list/PreviewSelectRow.tsx
client/web/src/enterprise/batches/preview/utils.ts
client/web/src/enterprise/batches/repo/BatchChangeRepoPage.story.tsx
client/web/src/enterprise/batches/useBatchChangesLicense.ts
client/web/src/enterprise/batches/workspaces-list/ListItem.story.tsx
@fkling client/search-ui/src/components/FileContentSearchResult.tsx
client/search-ui/src/input/CodeMirrorQueryInput.tsx
client/search-ui/src/input/SearchContextMenu.tsx
client/search-ui/src/input/codemirror/completion.test.ts
client/search-ui/src/input/toggles/Toggles.tsx
client/search-ui/src/results/AnnotatedSearchExample.tsx
client/search-ui/src/results/StreamingSearchResultsFooter.tsx
client/search-ui/src/results/sidebar/SearchReference.tsx
client/search-ui/src/results/sidebar/SearchSidebar.tsx
client/search/src/backend.ts
client/search/src/integration/streaming-search-mocks.ts
client/shared/src/search/query/completion.test.ts
client/shared/src/search/query/completion.ts
client/shared/src/search/query/hover.ts
client/shared/src/search/query/parserFuzz.ts
client/shared/src/search/query/patternMatcher.ts
client/shared/src/search/query/scanner.ts
client/web/src/search/Notepad.tsx
client/web/src/search/SearchConsolePage.tsx
client/web/src/search/backend.tsx
client/web/src/search/home/useQueryExamples.tsx
client/web/src/search/input/SearchNavbarItem.tsx
client/web/src/search/panels/CollaboratorsPanel.story.tsx
client/web/src/search/panels/CommunitySearchContextPanel.story.tsx
client/web/src/search/panels/RecentFilesPanel.tsx
client/web/src/search/panels/RecentSearchesPanel.tsx
client/web/src/search/panels/RepositoriesPanel.tsx
client/web/src/search/panels/SavedSearchesPanel.tsx
client/web/src/search/panels/utils.ts
client/web/src/search/results/components/aggregation/SearchAggregationResult.story.tsx
client/web/src/search/results/components/aggregation/components/aggregation-chart-card/components/AggregationChart.tsx
client/web/src/search/results/components/aggregation/hooks.ts
client/web/src/search/stats/contributions.ts
@limitedmage client/search-ui/src/components/FileContentSearchResult.tsx
client/search-ui/src/input/CodeMirrorQueryInput.tsx
client/search-ui/src/input/SearchContextMenu.tsx
client/search-ui/src/input/codemirror/completion.test.ts
client/search-ui/src/input/toggles/Toggles.tsx
client/search-ui/src/results/AnnotatedSearchExample.tsx
client/search-ui/src/results/StreamingSearchResultsFooter.tsx
client/search-ui/src/results/sidebar/SearchReference.tsx
client/search-ui/src/results/sidebar/SearchSidebar.tsx
client/web/src/enterprise/code-monitoring/CodeMonitoringPage.story.tsx
client/web/src/enterprise/code-monitoring/CodeMonitoringPage.test.tsx
client/web/src/enterprise/code-monitoring/CreateCodeMonitorPage.story.tsx
client/web/src/enterprise/code-monitoring/CreateCodeMonitorPage.tsx
client/web/src/enterprise/code-monitoring/ManageCodeMonitorPage.story.tsx
client/web/src/enterprise/code-monitoring/components/DeleteMonitorModal.story.tsx
client/web/src/enterprise/code-monitoring/components/FormTriggerArea.story.tsx
client/web/src/integration/code-monitoring.test.ts
client/web/src/search/Notepad.tsx
client/web/src/search/SearchConsolePage.tsx
client/web/src/search/backend.tsx
client/web/src/search/home/useQueryExamples.tsx
client/web/src/search/input/SearchNavbarItem.tsx
client/web/src/search/panels/CollaboratorsPanel.story.tsx
client/web/src/search/panels/CommunitySearchContextPanel.story.tsx
client/web/src/search/panels/RecentFilesPanel.tsx
client/web/src/search/panels/RecentSearchesPanel.tsx
client/web/src/search/panels/RepositoriesPanel.tsx
client/web/src/search/panels/SavedSearchesPanel.tsx
client/web/src/search/panels/utils.ts
client/web/src/search/results/components/aggregation/SearchAggregationResult.story.tsx
client/web/src/search/results/components/aggregation/components/aggregation-chart-card/components/AggregationChart.tsx
client/web/src/search/results/components/aggregation/hooks.ts
client/web/src/search/stats/contributions.ts
@philipp-spiess client/jetbrains/webview/src/search/input/JetBrainsToggles.tsx
client/jetbrains/webview/src/sourcegraphSettings.ts
@rvantonder client/shared/src/search/query/completion.test.ts
client/shared/src/search/query/completion.ts
client/shared/src/search/query/hover.ts
client/shared/src/search/query/parserFuzz.ts
client/shared/src/search/query/patternMatcher.ts
client/shared/src/search/query/scanner.ts
@vdavid client/jetbrains/webview/src/search/input/JetBrainsToggles.tsx
client/jetbrains/webview/src/sourcegraphSettings.ts

@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in OWNERS files for diff 3a774ed...a1bd503.

Notify File(s)
@sourcegraph/code-exploration-devs client/common/src/util/LocalStorageSubject.ts
client/common/src/util/markdown/markdown.ts
client/common/src/util/rxjs/repeatUntil.test.ts
client/common/src/util/rxjs/repeatUntil.ts
client/common/src/util/types.ts
client/http-client/src/graphql/apollo/client.ts
client/observability-client/src/instrumentations/fetch.ts
client/wildcard/src/components/Alert/Alert.story.tsx
client/wildcard/src/components/Charts/components/bar-chart/components/TooltipContent.tsx
client/wildcard/src/components/Charts/components/line-chart/LineChart.tsx
client/wildcard/src/components/Charts/components/pie-chart/PieChart.tsx
client/wildcard/src/components/Charts/core/components/SvgRoot.tsx
client/wildcard/src/components/Feedback/FeedbackPrompt/FeedbackPrompt.tsx
client/wildcard/src/components/Form/FlexTextArea/FlexTextArea.tsx
client/wildcard/src/components/Form/RadioButton/RadioButton.tsx
client/wildcard/src/components/PageHeader/PageHeader.story.tsx
client/wildcard/src/components/PageSwitcher/PageSwitcher.story.tsx
client/wildcard/src/components/Tabs/Tabs.story.tsx
@vovakulikov client/wildcard/src/components/Alert/Alert.story.tsx
client/wildcard/src/components/Charts/components/bar-chart/components/TooltipContent.tsx
client/wildcard/src/components/Charts/components/line-chart/LineChart.tsx
client/wildcard/src/components/Charts/components/pie-chart/PieChart.tsx
client/wildcard/src/components/Charts/core/components/SvgRoot.tsx
client/wildcard/src/components/Feedback/FeedbackPrompt/FeedbackPrompt.tsx
client/wildcard/src/components/Form/FlexTextArea/FlexTextArea.tsx
client/wildcard/src/components/Form/RadioButton/RadioButton.tsx
client/wildcard/src/components/PageHeader/PageHeader.story.tsx
client/wildcard/src/components/PageSwitcher/PageSwitcher.story.tsx
client/wildcard/src/components/Tabs/Tabs.story.tsx

yarn.lock Show resolved Hide resolved
@@ -489,7 +489,7 @@
"cssnano": "4.1.10",
"webpack": "5",
"tslib": "2.1.0",
"prettier": "2.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat why did we pin it to 2.2 but the package json says 2.7 👀

@@ -489,7 +489,6 @@
"cssnano": "4.1.10",
"webpack": "5",
"tslib": "2.1.0",
"prettier": "2.8.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see

@valerybugakov valerybugakov merged commit 260561a into main Dec 8, 2022
@valerybugakov valerybugakov deleted the vb/upgrade-prettier branch December 8, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants