Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enterprise import lint rule reference link #26628

Merged
merged 1 commit into from Oct 26, 2021

Conversation

xg-wang
Copy link
Contributor

@xg-wang xg-wang commented Oct 26, 2021

It looks like the link has changed since #23044

Question: can dev/check/ts-enterprise-import.sh in dev/check/all.sh be removed since there's eslint rule?

@cla-bot cla-bot bot added the cla-signed label Oct 26, 2021
@xg-wang
Copy link
Contributor Author

xg-wang commented Oct 26, 2021

@valerybugakov I came across this while doing #26177

Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: can dev/check/ts-enterprise-import.sh in dev/check/all.sh be removed since there's eslint rule?

@xg-wang, Ideally, it should be deleted in favor of the ESLint rule, but there's one limitation to the current ESLint rule implementation:

  1. We want to limit the depth of the relative imports to one level
  2. It means that we will see more absolute imports, which would have **/enterprise/* in the path, even in modules under the enterprise folder.
  3. The current ESLInt configuration would give us a false positive in that case.

I've created an issue about ESLint rule improvement: #26639
And another one about documentation links based on your PR: #26633.

Thank you for raising these questions!

@valerybugakov valerybugakov enabled auto-merge (squash) October 26, 2021 09:29
@valerybugakov valerybugakov merged commit a66c738 into sourcegraph:main Oct 26, 2021
@xg-wang xg-wang deleted the xgwang/enterprise-lint branch October 26, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants