logger: remove log scope debug message #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
commented
Sep 18, 2023
Comment on lines
-141
to
-142
| // createdScopes tracks the scopes that have been created so far. | ||
| var createdScopes sync.Map |
There was a problem hiding this comment.
I think once upon a time there was an idea to have a debug endpoint where you can take a scope and look up "what's this scope about"
unknwon
approved these changes
Sep 18, 2023
burmudar
approved these changes
Sep 18, 2023
bobheadxi
added a commit
to sourcegraph/sourcegraph
that referenced
this pull request
Sep 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added early on to show descriptions of log scopes somewhere. It's pretty useless, and noisy - let's just get rid of it
aside: the scope description parameter in general is pretty useless as well, maybe someone can do the honors of getting rid of that as well :)