switch from yarn to pnpm #5952
Merged
switch from yarn to pnpm #5952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying subscribers in CODENOTIFY files for diff 5d29fb7...3286c85.
|
sqs
force-pushed
the
sqs/use-pnpm
branch
4 times, most recently
from
bbaff4b
to
bbc083d
Compare
vovakulikov
previously approved these changes
Jan 15, 2023
|
Oh just noticed that E2E testes are failing on CI. I think this might be some sort of problem similar to what we have with esbuild in main repo |
We are now using pnpm in the main repository (https://github.com/sourcegraph/sourcegraph). Let's switch to pnpm here, too, for consistency.
|
@vovakulikov Thanks for the catch on the wrong commit message. And the e2e tests are a different issue (node17+ jeffbski/wait-on#109 (comment)). Should be fixed. (Unless you are referring to a different esbuild-related issue.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using pnpm in the main repository (https://github.com/sourcegraph/sourcegraph). Let's switch to pnpm here, too, for consistency.
Also adds deps in package.json that were imported from but not mentioned. pnpm (correctly) flagged these.