Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting for grading #1107

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

thortol
Copy link

@thortol thortol commented Apr 8, 2024

Description

To be merged with Frontend #2893

For implementation decisions, see Frontend PR.

Changes

  • Changed submissions_by_grader_for_index pipeline by adding user table, assessment.title and assessment.config_id
  • Added sort_submission to sort the query in the pipeline

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Apr 8, 2024

Coverage Status

coverage: 94.978% (-0.3%) from 95.295%
when pulling b1c1061 on thortol:add-sorting-for-grading
into 4e55b6a on source-academy:master.

@RichDom2185
Copy link
Member

Is this PR ready?

@thortol thortol marked this pull request as ready for review April 14, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants