-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] treat calls to abstract methods in static same as runtime #7853
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com> Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
0d2e264
to
6caeb5e
Compare
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_PyonPSf2YqKNS1 |
auto possiblities = symbol.data(gs)->findParentMethodTransitiveAll(gs, targetName); | ||
for (auto overload : possiblities) { | ||
if (!overload.data(gs)->flags.isAbstract) { | ||
mayBeOverloaded = overload; | ||
break; | ||
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto possiblities = symbol.data(gs)->findParentMethodTransitiveAll(gs, targetName); | |
for (auto overload : possiblities) { | |
if (!overload.data(gs)->flags.isAbstract) { | |
mayBeOverloaded = overload; | |
break; | |
} | |
} | |
} | |
auto possibilities = symbol.data(gs)->findParentMethodTransitiveAll(gs, targetName); | |
for (auto overload : possibilities) { | |
if (!overload.data(gs)->flags.isAbstract) { | |
mayBeOverloaded = overload; | |
break; | |
} | |
} | |
} | |
Motivation
Test plan
See included automated tests.