[Ruby 3.0] Reject ->... and ->(...) using the same error #4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_JrGwbsXf0YtDak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement this change: whitequark/parser#713
Based on my reviews of the commits in whitequark, this should be the last of the parser/lexer/builder changes for feature parity with Ruby 3.0 (unless I missed something 😅).
This PR updates the import whitequark script with the SHA of the latest Ruby 3.0 parser commit and sets the target as Ruby 3.0.
Additionally, it implements the brief lexer change mentioned.
Motivation
Complete Ruby 3.0 support.
Test plan
The existing tests that were previously imported should cover this.