[Ruby 3.0] Reserved for numparams #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
ruby30-reserved-for-numparams
branch
from
ad3ed13
to
4a4d488
Compare
froydnj
requested changes
Jul 1, 2021
vinistock
force-pushed
the
ruby30-reserved-for-numparams
branch
from
4a4d488
to
96473c9
Compare
|
@froydnj fixed the hidden definition generation in the latest commit. |
froydnj
approved these changes
Jul 7, 2021
| @@ -57,7 +57,7 @@ tuple<string, string> MESSAGES[] = { | |||
| {"InvalidRegexp", "{}"}, | |||
| {"InvalidReturn", "invalid return in class/module body"}, | |||
| {"CSendInLHSOfMAsgn", "&. inside multiple assignment destination"}, | |||
| {"CantAssignToNumparam", "cannot assign to numbered parameter {}"}, | |||
| {"ReservedForNumparam", "{} is reserved for numbered parameter"}, | |||
There was a problem hiding this comment.
I don't know if this is the best error message, but I think we can fix this in a followup.
There was a problem hiding this comment.
Agreed. I used the same message Ruby uses.
elliottt
added a commit
that referenced
this pull request
Jul 8, 2021
vinistock
added a commit
to vinistock/sorbet
that referenced
this pull request
Jul 12, 2021
Revert: (sorbet#4337) Original: (sorbet#4323) This reverts commit f2f50a0.
vinistock
added a commit
to vinistock/sorbet
that referenced
this pull request
Jul 14, 2021
Revert: (sorbet#4337) Original: (sorbet#4323) This reverts commit f2f50a0. Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
vinistock
added a commit
to vinistock/sorbet
that referenced
this pull request
Aug 16, 2021
Revert: (sorbet#4337) Original: (sorbet#4323) This reverts commit f2f50a0. Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
vinistock
added a commit
to vinistock/sorbet
that referenced
this pull request
Aug 18, 2021
Revert: (sorbet#4337) Original: (sorbet#4323) This reverts commit f2f50a0. Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
elliottt
pushed a commit
that referenced
this pull request
Aug 18, 2021
* [Ruby 3.0] Add reserved for numparams errors to all usages Revert: (#4337) Original: (#4323) This reverts commit f2f50a0. Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com> * Autocorrect reserved numbered parameters from `_[0-9]` to `arg[0-9]` Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com> * Use errors-with-dup for reserved numparams Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com> * Add tests and builder changes related to endless methods combined with numbered parameters Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com> * Use a new error class to be able to supress reserved numparam errors * Fix numbered parameters test cases Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes for Ruby 3.0 to numbered parameters based on whitequark/parser#725.
The change is to check that the reserved names for numbered parameters are not used anywhere except for numbered parameters themselves.
I had to update some unrelated RBIs and tests because they used these reserved names and started throwing the new error. It might be easier to review per commit.
Motivation
In Ruby 2.7, assigning a numbered parameter would throw an error only inside blocks. That is
Since Ruby 3.0, the numbered parameter names are actually reserved everywhere. Trying to use
_1as a variable, method definition or any type of argument will throw an error and the message has changed.Test plan
See included automated tests.