Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update argument forwarding syntax #4247

Merged
merged 4 commits into from Jun 8, 2021
Merged

Update argument forwarding syntax #4247

merged 4 commits into from Jun 8, 2021

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jun 3, 2021

Motivation

Update parser to new forward argument syntax.

Port of whitequark/parser#710.

Test plan

See included automated tests.

Morriar and others added 2 commits June 3, 2021 18:27
@Morriar @vinistock
Update imported tests for forward arguments
e05defe 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
@Morriar @vinistock
Update parser for new forward arguments syntax
6376d1b 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
@Morriar Morriar requested a review from a team as a code owner June 3, 2021 22:30
@Morriar Morriar requested review from froydnj and removed request for a team June 3, 2021 22:30
froydnj
froydnj reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! Just some minor notes on comments that need updating.

resolver/resolver.cc Outdated Show resolved Hide resolved
ast/desugar/Desugar.cc Outdated Show resolved Hide resolved
froydnj
froydnj reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, click the appropriate button before "Submit review"...see previous comments, please.

froydnj
froydnj requested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third time's the charm!

Morriar and others added 2 commits June 8, 2021 11:38
@Morriar @vinistock
Update desugar for new forward arguments syntax
c09bdbc 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
@Morriar @vinistock
Update resolver for new forward argument syntax
f3772f3 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
@Morriar Morriar requested a review from froydnj June 8, 2021 15:42
froydnj
froydnj approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@froydnj froydnj merged commit fd8d978 into sorbet:master Jun 8, 2021
@Morriar Morriar deleted the at-ruby27-fwd-args branch June 8, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froydnj froydnj froydnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Morriar @froydnj