[refactor]: some refactors in Remove Liquidity #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `PairAddressResult` as a source of truth in more places (less duplication) - rename the store's `isPairLoaded` to `doesPairExist` for better semantics - clear selected addrs at `.clear()` - when "supply" is closed, navigate to liquidity only when the supply was fulfilled - on refresh, update the pair address too
Sociopacific
approved these changes
Dec 12, 2022
| @@ -25,7 +25,7 @@ const { loading: isLoading, result, refetch } = useLiquidityPairsQuery(pollInter | |||
| // Refetch if cached | |||
| if (result.value && !isLoading.value) refetch() | |||
|
|
|||
| const isLoaded = computed(() => !!result.value) | |||
| // const isLoaded = computed(() => !!result.value) | |||
There was a problem hiding this comment.
Do we need it anymore? I think we can use isLoading to display loader instead of "Empty"
There was a problem hiding this comment.
Yeah, I think we can. But I intentionally avoid to do it, because I think it could be solved in the whole app in general in a single run. There are many places where loaders should be nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes klaytn#174