Copy updates, README, 1 minute expiration #95
Conversation
***Copy text*** * The feature recently added required additional copy text. Also, the README now mentions this feature ***1 Minute*** * A new, shorter duration option is added (1 minute). Since the note can be viewed multiple times, it seems like it would be fun to set a really short duration on when it can be viewed. One could post it to a chat channel, or text thread, and force everybody to view it quickly.
|
For the sake of short duration notes, a box could be included (and copyable) on the or |
|
|
||
| describe "#sendable_message" do | ||
| it 'says' do | ||
|
|
There was a problem hiding this comment.
Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
| @@ -20,4 +20,10 @@ | |||
| expect(page_presenter.optional_fields_state).to eq("") | |||
| end | |||
| end | |||
|
|
|||
| describe "#sendable_message" do | |||
| it 'says' do | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| # Settings in config/environments/* take precedence over those specified here. | ||
| # Application configuration should go into files in config/initializers | ||
| # -- all .rb files in that directory are automatically loaded. | ||
|
|
||
| # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone. | ||
| # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC. | ||
| # config.time_zone = 'Central Time (US & Canada)' | ||
| config.time_zone = 'Eastern Time (US & Canada)' |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -30,13 +30,16 @@ class Application < Rails::Application | |||
| end | |||
|
|
|||
| config.action_controller.action_on_unpermitted_parameters = :raise | |||
| Rails.application.routes.default_url_options[:host] = ENV.fetch('HOST') | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| message += ")" | ||
| message += " It can only be viewed once." unless multiview? | ||
| message += " " | ||
| message += link |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - message. Use + instead of +=.
| message += " that expires in #{time_until_expiration}" | ||
| message += " (" | ||
| message += "#{expires_at.in_time_zone.strftime("%m/%d/%Y")}" | ||
| message += " at #{expires_at.in_time_zone.strftime("%I:%M%p %Z")}." |
There was a problem hiding this comment.
Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
| message = "Here is a link to a onetime note" | ||
| message += " that expires in #{time_until_expiration}" | ||
| message += " (" | ||
| message += "#{expires_at.in_time_zone.strftime("%m/%d/%Y")}" |
There was a problem hiding this comment.
Style/UnneededInterpolation: Prefer to_s over string interpolation.
Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
Copy text
README now mentions this feature
1 Minute
be viewed multiple times, it seems like it would be fun to set a really
short duration on when it can be viewed. One could post it to a chat
channel, or text thread, and force everybody to view it quickly.