Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final 8.0 release prep #2606

Merged
merged 4 commits into from
Jun 2, 2024
Merged

Final 8.0 release prep #2606

merged 4 commits into from
Jun 2, 2024
+11 −6

Conversation

dgw
Copy link
Member

@dgw dgw commented Apr 24, 2024

Description

My own branch protection settings won't let me commit a quick fix directly to master, so I guess I'll open a catch-all PR for this and any other stuff that was forgotten as part of #2600.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
    • Didn't touch code, so if something breaks it's not my fault 🙃
  • I have tested the functionality of the things this change touches
    • Ditto above, didn't touch code

@dgw dgw added this to the 8.0.0 milestone Apr 24, 2024
@SnoopJ
Copy link
Contributor

SnoopJ commented Apr 25, 2024

Not sure if this is a draft because you intend to add other things, or in case we spot something that needs adding. Either way, changes in it as of now LGTM.

@dgw
Copy link
Member Author

dgw commented Apr 25, 2024

It is a draft for both reasons, until the website stuff is done. Then I'll have to version-bump as part of the PR (because of those branch protection rules already mentioned). 😁

@dgw dgw mentioned this pull request Apr 28, 2024
Merged
dgw added 2 commits May 26, 2024 19:47
@dgw
Release 8.0.0
2613c56 
Have to commit this so it can be integrated with the website build. Not
yet clear if the release tag will point to this commit or a merge.
@dgw
meta: remove emails from author/maintainer metadata
3261d9c 
Since pypi/warehouse#9400 and pypi/warehouse#14813 (perhaps others too)
remain unresolved, let's keep our metadata simple. Incomplete metadata—
i.e. the email addresses this commit removes—is the only thing worse
than straight-up *incorrect* metadata. We don't want any author or
maintainer names to be attached to the wrong email addresses on the
published package page.
@dgw
Copy link
Member Author

dgw commented May 27, 2024

I uploaded a build of 3261d9c to https://test.pypi.org/project/sopel/8.0.0/ and everything seems to work.

Speaking of 3261d9c, when I examine (Test)PyPI's JSON API output, I can see that sopel-pypi will show the whole author list ("dgw, Florian Strzelecki, Sean B. Palmer, [etc.]"). Previous releases have only listed me as the author, and we are correcting that in the 8.x series. (Let's think of this as an opportunity to find sopel-pypi output improvements.)

The whole list is arguably still better than "(unknown name)", which is what it does for projects with both a name and email, like many of the plugins I/we have switched over to pyproject.toml metadata. There seems to be an unsolved issue in Python's ecosystem relating to pyproject.toml / PEP 621 metadata and non-empty email; see pypi/warehouse#9400 (and also pypi/warehouse#14813, a related but distinct issue with specifying email for some-but-not-all authors or maintainers).

@dgw dgw marked this pull request as ready for review May 27, 2024 01:18
@dgw dgw requested review from Exirel and SnoopJ May 27, 2024 01:18
Exirel
Exirel approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the test index to install Sopel 8 and it installed successfully, without any problem for the help plugin. I couldn't run it because I tested on my work's network and they don't allow IRC. However sopel-config and sopel-plugins did work as intended.

Let's. Freaking. Go.

@dgw
Copy link
Member Author

dgw commented May 31, 2024

I used the test index to install Sopel 8 and it installed successfully, without any problem for the help plugin.

Is this a reference to sopel-irc/sopel-help#11? I'm sure it doesn't affect all (or even most) Python environments; how common is it not to have setuptools installed at all? 😂 But that's also an issue for sopel-help to solve if necessary, and definitely shouldn't be a blocker for the main bot itself. That was the whole point of starting to extract nonessential plugins from core 😁

@Exirel
Copy link
Contributor

Exirel commented May 31, 2024

Not even a ref to that, I just made sure that the install worked as intended because sopel-help must not break Sopel's install.

SnoopJ
SnoopJ approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@SnoopJ SnoopJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it count as super-approving if I accidentally approve it from my work account first? 🤦

@dgw dgw merged commit 4ac50a6 into master Jun 2, 2024
13 checks passed
@dgw dgw deleted the 8.0-final-prep branch June 2, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

@SnoopJ SnoopJ SnoopJ approved these changes

@jgerityneurala jgerityneurala jgerityneurala approved these changes

Assignees
No one assigned
Labels
Documentation Tweak
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgw @SnoopJ @Exirel @jgerityneurala