Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dev-requirements.txt with a [dev] extra #2364

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Oct 24, 2022

Description

This PR removes dev-requirements.txt and moves the optional development dependencies it defines into a new [dev] extra. Closes #2363

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Oct 24, 2022
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will happily merge this once squashed. Maybe the final commit message is something like install: use [dev] extra instead of dev-requirements.txt?

(We like our easily scannable module/component prefixes, if you couldn't tell. 😛)

@SnoopJ
Copy link
Contributor Author

SnoopJ commented Oct 24, 2022

I will happily merge this once squashed. Maybe the final commit message is something like install: use [dev] extra instead of dev-requirements.txt?

(We like our easily scannable module/component prefixes, if you couldn't tell. stuck_out_tongue)

Yea, I just didn't know which one made the most sense here, will use install in the squash.

Can you drop the best reference on the flake8 issue this uncovered?

@dgw
Copy link
Member

dgw commented Oct 25, 2022

Can you drop the best reference on the flake8 issue this uncovered?

Uh, that's probably PyCQA/flake8#1004 though there are numerous threads from consumers trying to solve the incompatibility later (post-release) on both flake8's and importlib_metadata's repos.

Co-authored-by: dgw <dgw@technobabbl.es>
@dgw dgw merged commit 9014653 into sopel-irc:master Oct 25, 2022
@dgw
Copy link
Member

dgw commented Jan 4, 2023

Ultimately reverted in #2392, due to workflow issues we can't solve with pip. The "eager" upgrade strategy doesn't work the way we thought, so it became difficult to keep dev-deps up to date.

@SnoopJ SnoopJ deleted the feature/define-dev-extra branch November 19, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dev requirements into an extra
2 participants