fix: When the organization ID is changed the application should be moved #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madpah
requested changes
May 16, 2024
Added a prefix to created resources in tests, if the test fails and a resource is left dangling it makes it easier to identify. Signed-off-by: grahamhar <grahamhar@users.noreply.github.com>
|
|
madpah
approved these changes
May 28, 2024
|
Running tests get the error: Will work on a patch for the tests @grahamhar. |
Oh so I guess we have to set up another org to do the test 😟, I'm happy to work on that if you are busy |
|
Yup - done and tests running on main... |
|
Looks good now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been unable to run the new tests as is as I don't have access to the root org in our installation. I did test by using 2 orgs I do have access to so quite confident the proposed solution is OK. I wanted to avoid having to setup an org just for this test, happy to update to using that approach if the root org can't be used for some reason.
I have also added a prefix to created resources in tests, if the test fails and a resource is left dangling it makes it easier to identify.
closes: #25