DX: Use prestissimo #403
DX: Use prestissimo #403
Conversation
.travis.yml
Outdated
| @@ -22,7 +22,8 @@ before_install: | |||
| - wget http://cs.sensiolabs.org/download/php-cs-fixer-v2.phar --output-document=php-cs-fixer.phar | |||
|
|
|||
| install: | |||
| - composer update --prefer-dist --no-interaction $COMPOSER_FLAGS | |||
| - composer global show hirak/prestissimo -q || travis_retry composer global require hirak/prestissimo --prefer-dist --no-interaction --no-progress $COMPOSER_FLAGS | |||
There was a problem hiding this comment.
ref #173 (comment)
if prestissimo is already installed, we don't need to install it again.
so same time as project dependencies are cached and prestissimo is not bringing that big benefits, we could cache it as well, so we won't lose any time if it's already there.
so with this change, we have 2 scenarios:
- no composer cache, install
prestissimoplugin and then deps using plugin - composer cache is there, don't install plugin and install deps from cache
There was a problem hiding this comment.
no need for composer flags here AFAIK, only for the composer update command
There was a problem hiding this comment.
sure, I didn't found where that env var was set and what you provide as a value, so I kept it as is. dropping...
.travis.yml
Outdated
| @@ -22,7 +22,8 @@ before_install: | |||
| - wget http://cs.sensiolabs.org/download/php-cs-fixer-v2.phar --output-document=php-cs-fixer.phar | |||
|
|
|||
| install: | |||
| - composer update --prefer-dist --no-interaction $COMPOSER_FLAGS | |||
| - composer global show hirak/prestissimo -q || travis_retry composer global require hirak/prestissimo --prefer-dist --no-interaction --no-progress | |||
There was a problem hiding this comment.
Please add some linebreaks here.
There was a problem hiding this comment.
like between this and next install steps, or to split this line? not sure what you mean to be honest.
well, in the end I left allowance to modify my PR to you guys, so feel free to add them yourself however you want to have them!
There was a problem hiding this comment.
Just to split this line, but yeah I can amend it.
.travis.yml
Outdated
| - | | ||
| composer global show hirak/prestissimo --quiet || | ||
| travis_retry composer global require hirak/prestissimo --prefer-dist --no-interaction --no-progress | ||
| - composer update --prefer-dist --no-interaction --no-progress $COMPOSER_FLAGS |
There was a problem hiding this comment.
This composer flags is suspicious, I can't find it defined anywhere :P
There was a problem hiding this comment.
See 24cf39a , looks like they were never defined at all
There was a problem hiding this comment.
so same as me ;)
if you want to drop it, let us not mix the things and drop it in separate PR please
| @@ -10,7 +10,7 @@ sudo: false | |||
|
|
|||
| cache: | |||
| directories: | |||
| - $HOME/.composer/cache/files | |||
| - $HOME/.composer | |||
There was a problem hiding this comment.
Hmm, caching the whole composer directory looks dangerous to me. Why this is needed?
There was a problem hiding this comment.
to have prestissimo cached. whole point of this PR.
I am caching whole composer for 3+ years, never had any issues because of that.
Why you find it dangeroues ?
There was a problem hiding this comment.
I find it dangerous because we might have not wanted cached file and I already add not wanted dependencies issues before.
But it was a long time ago, let's give a try.
There was a problem hiding this comment.
well, you can put anything in cache, what would be the outcome deps depends only on composer.* files, not cache
|
conflict resolved |
|
Thanks! |
The gain won't be big, but I'm showing the approach how #173 shall be done.
If you want it - take it, if not ,close PR, no bad feelings !