Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Composer parallel installs with hirak/prestissimo plugin #173

Closed
soullivaneuh opened this issue Jun 16, 2016 · 6 comments
Closed
Assignees

Comments

@soullivaneuh
Copy link
Member

https://packagist.org/packages/hirak/prestissimo

Try this plugin on a "big" project to see if it worth it.

Ref: PHP-CS-Fixer/PHP-CS-Fixer#1995

@soullivaneuh soullivaneuh self-assigned this Jun 16, 2016
@keradus
Copy link
Contributor

keradus commented Jun 16, 2016

just be sure to use at least ^0.2 if you use Composer ^1

@soullivaneuh
Copy link
Member Author

just be sure to use at least ^0.2 if you use Composer ^1

Thanks for the tip, we will use the latest one! 😉

@soullivaneuh
Copy link
Member Author

After a composer clearcache and deleted vendor on admin-bundle, I tried a composer install:

  • Without the plugin: 1m17s
  • With the plugin: 0m29s

This is indeed a great addition to have.

@keradus
Copy link
Contributor

keradus commented Jun 16, 2016

You see, I know what am I doing ;)
Be aware that the boos is not that big when the deps is already cached (but then, you will have prestissimo cached as well, right? ;) )

@soullivaneuh
Copy link
Member Author

You see, I know what am I doing ;)

If you are talking about adding phpunit as a project dev, sorry but I still disagree. 😛

Be aware that the boos is not that big when the deps is already cached (but then, you will have prestissimo cached as well, right? ;) )

Yes we are caching composer files:

- $HOME/.composer/cache/files

But cache has a timeout, so...

@jordisala1991
Copy link
Member

I cant find where, but I know I already tested it on travis (and @greg0ire / you saw it) and we didnt gain any performance, due to the cache @keradus mentioned, and the fact that we are doing another command to install prestissimo in the first place.

Closing for now, feel free to reopen if this needs to be checked again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants