Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent to go to createByPage methode on Page deletion #1721

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Prevent to go to createByPage methode on Page deletion #1721

merged 1 commit into from
Nov 19, 2023

Conversation

GeraudBourdin
Copy link
Contributor

@GeraudBourdin GeraudBourdin commented Nov 19, 2023 •
edited by VincentLanglet

Closes #1708.

Changelog

### Fixed
- Removal of a page

@GeraudBourdin GeraudBourdin mentioned this pull request Nov 19, 2023
Closed
@VincentLanglet VincentLanglet changed the title Prevent to go to createByPage methode on Page deletion (what we want … Prevent to go to createByPage methode on Page deletion Nov 19, 2023
@VincentLanglet VincentLanglet merged commit 1ba9484 into sonata-project:4.x Nov 19, 2023
22 of 24 checks passed
@VincentLanglet
Copy link
Member

Thanks

@VincentLanglet VincentLanglet mentioned this pull request Nov 19, 2023
Closed
@GeraudBourdin
Copy link
Contributor Author

thanks for the approuval. If we want to see it in the 5.x-dev do we need to provide another PR targeting this branch ?

@eerison
Copy link
Contributor

eerison commented Nov 19, 2023

Are you using 5.x branch @GeraudBourdin ?

@GeraudBourdin
Copy link
Contributor Author

"^5.x-dev" yes, not in production but we are building a bundle with this branch.

@VincentLanglet
Copy link
Member

thanks for the approuval. If we want to see it in the 5.x-dev do we need to provide another PR targeting this branch ?

The merge was done automatically on 5.x

@GeraudBourdin
Copy link
Contributor Author

thanks for the approuval. If we want to see it in the 5.x-dev do we need to provide another PR targeting this branch ?

The merge was done automatically on 5.x

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing a page doesn't work from the edit route (works using batch delete)
3 participants
@GeraudBourdin @VincentLanglet @eerison