Fix deleted blocks (from composer) still visible

[gremo]

Subject

I am targeting this branch, because this is a bugfix.

Closes #1292

Changelog

### Added
- Added `CreateSnapshotAdminExtension::postRemove()` method in order to create a snapshot when a block is deleted.

[haivala]

I think this is not needed. This is how it should work. You should be able choose when to publish the changes manually by doing for example timed publication. If this patch is for direct publication then go for it.

[gremo]

@haivala what?! This is how it should work? So, why it's working when you edit the block?

[haivala]

@haivala what?! This is how it should work? So, why it's working when you edit the block?

When you edited the block you were checking it probably with logged in user or you have direct publication set on? Either way anonymous user should always see only data from publications and the edits should not make publications unless you have direct publication setting on. Am I right?

[gremo]

@haivala as you can see here #1292 I'm using anonymous tab, so in the "black" Chrome window user is not logged.

I use direct publication YES - that means that:

• Adding a block should create a publication - WORKING
• Editing a block should create a publication - WORKING
• Deleting a block should create a publication - NOT WORKING <-- this is what this PR is trying to accomplish

If you think that my PR breaks something when direct publication is OFF, let's talk about it:

• CreateSnapshotAdminExtension is going to publish the "create a snapshot message"
• When direct_publication is off, sonata.page.admin.extension.snapshot service (that is, the subject of this PR) is removed by the extension, so no message is dispatched, so snapshot is not created

Am I right?

[haivala]

You are right!
Thank you for making this clear!

[gremo]

I'ts OK to merge @VincentLanglet ?

[VincentLanglet]

I don't use this bundle, so I'd like to get another review. Please take a look @sonata-project/contributors

[phansys]

Could we have some tests covering this fix?

[gremo]

Could we have some tests covering this fix?

Yes I can try if there is already some kind of testing for the block admin estension.

[franmomu]

Yes I can try if there is already some kind of testing for the block admin estension.

Actually, there is:
https://github.com/sonata-project/SonataPageBundle/blob/591a224473caee21233562f9935800bd32b0c38a/tests/Admin/Extension/CreateSnapshotAdminExtensionTest.php

[gremo]

Added tests, please merge (maybe release?) thank youuuu

[franmomu]

Thanks @gremo !