Fix menu in long-running process (RoadRunner, ReactPHP, Amphp) #7885
Conversation
In order to have new instance for every request in Long-running process (ReactPHP, Amphp, RoadRunner)
There was a problem hiding this comment.
Otherwise menu is created once and then re-used - and that doesn't work if there is dynamic content in the menu.
@Warxcell Is there a way to add a test about the use-case which didn't work ?
| @@ -33,6 +33,7 @@ | |||
| ]) | |||
|
|
|||
| ->set('sonata.admin.sidebar_menu', MenuItem::class) | |||
| ->share(false) | |||
There was a problem hiding this comment.
if we cant add a test, we should at least leave a comment about why we do this, imho
There was a problem hiding this comment.
Otherwise menu is created once and then re-used - and that doesn't work if there is dynamic content in the menu.
@Warxcell Is there a way to add a test about the use-case which didn't work ?
Sure. Adding it atm.
phpunit.xml.dist
Outdated
| @@ -33,5 +33,6 @@ It's auto-generated by sonata-project/dev-kit package. | |||
| <php> | |||
| <ini name="precision" value="8" /> | |||
| <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0" /> | |||
| <env name="KERNEL_CLASS" value="Sonata\AdminBundle\Tests\App\AppKernel" /> | |||
There was a problem hiding this comment.
This file is autogenerated and cannot be touched.
Please add
protected static function getKernelClass(): string
{
return AppKernel::class;
}
instead in your MenuTest file if needed
Warxcell
changed the title
|
Failure in PSALM seems unrelated 🤷 |
I'm on it |
| public function testDynamicMenuInLongRunningProcess(): void | ||
| { | ||
| $client = static::createClient(); | ||
| $client->disableReboot(); |
There was a problem hiding this comment.
This is what makes the client share the same container? If yes, can you add a comment here to explain this line (ex: this ensures the container is reused across multiple request to simulate the behavior of ...)?
|
For psalm it's related to vimeo/psalm#8330 ; we will need to ignore the issue |
|
Thanks ! |
In order to have new instance for every request in Long-running process (ReactPHP, Amphp, RoadRunner).
Otherwise menu is created once and then re-used - and that doesn't work if there is dynamic content in the menu, since first request creates the menu and then all other requests uses the menu created by first request.
Subject
I am targeting this branch, because bugfix.
Changelog