Avoid collisions with cache keys at AbstractAdmin::isGranted()
#6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
reviewed
Apr 12, 2020
franmomu
reviewed
Apr 12, 2020
franmomu
reviewed
Apr 12, 2020
franmomu
previously approved these changes
Apr 12, 2020
VincentLanglet
previously approved these changes
Apr 12, 2020
greg0ire
approved these changes
Apr 14, 2020
franmomu
approved these changes
Apr 14, 2020
|
Thanks @phansys ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Avoid collisions with cache keys at
AbstractAdmin::isGranted().I am targeting this branch, because this change respects BC.
I'd like to reproduce the reported issue in the test case, but I can't find the way to generate the collisions between consecutive calls to
spl_object_hash()inside the test case (ref).Closes #5621.
Changelog