Use createStub whenever possible #6043
Conversation
|
|
||
| $datagrid = $this->createMock(DatagridInterface::class); | ||
| $datagrid = $this->createStub(DatagridInterface::class); |
There was a problem hiding this comment.
The following line calls expects(). Isn't that the case where the test double should be considered as a mock according the issue referenced in the Rector (sebastianbergmann/phpunit#3120 (comment))?
There was a problem hiding this comment.
🤔 well spotted… guess the rule does not work properly
There was a problem hiding this comment.
If the tests are not failing when you expect something on a Stub, I don't really see the benefit of using it. Using both seems just confusing to me.
But that's a Phpunit debate.
There was a problem hiding this comment.
The tests that should fail are static analysis tests, and we don't have those for now, so indeed, let's maybe not merge this until we do.
Using both seems just confusing to me.
I think the main goal is precisely to clear the confusion between a stub and a mock, which serve different purposes as outlined in the linked issue above. It's never been super clear to me, but I think if I start using different words, I will start noticing patterns and use them when appropriate.
There was a problem hiding this comment.
I reported the bug here: rectorphp/rector#3157
Just wanted to try the rector class I failed to contribute: rectorphp/rector#3042