Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctrine/orm 3 support #590

Draft
wants to merge 4 commits into
base: 1.x
Choose a base branch
from

Conversation

franmomu
Copy link
Member

Subject

This PR tries to add support for doctrine/orm 3

I am targeting this branch, because these changes are BC.

Changelog

### Added
- Support for `doctrine/orm` 3

The CI should be modified to allow installing doctrine/orm 3

@franmomu franmomu added the minor label Nov 19, 2023
src/AuditReader.php Outdated Show resolved Hide resolved
@franmomu
Copy link
Member Author

We need doctrine/data-fixtures#452

@greg0ire
Copy link

greg0ire commented Nov 25, 2023

The next blocker seems to be doctrine-extensions/DoctrineExtensions#2708

@franmomu
Copy link
Member Author

The next blocker seems to be doctrine-extensions/DoctrineExtensions#2708

Yep, that would take a bit longer I think, I'll try to help with that

@VincentLanglet
Copy link
Member

Hi @franmomu, what about following the same strategy than https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/4.x/.github/workflows/test_orm_3.yaml ?

gedmo/doctrine-extensions is an optional dev dependency, it should be a blocker for the ORM 3 support.

@amacrobert-meq
Copy link

Is there anything I can do to help this PR along? This bundle is holding up an ORM upgrade on our end, so I'm happy to help if I can.

@VincentLanglet
Copy link
Member

Is there anything I can do to help this PR along? This bundle is holding up an ORM upgrade on our end, so I'm happy to help if I can.

Basically, we need green tests.

If you want you can recreate the same PR and add a github actions similar to https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/4.x/.github/workflows/test_orm_3.yaml

Instead of removing AuditBundle you remove the doctrineExtensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants