New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doctrine/orm
3 support
#590
base: 1.x
Are you sure you want to change the base?
Conversation
We need doctrine/data-fixtures#452 |
dc61ab4
to
abd07bd
Compare
abd07bd
to
9e00c2f
Compare
The next blocker seems to be doctrine-extensions/DoctrineExtensions#2708 |
Yep, that would take a bit longer I think, I'll try to help with that |
Hi @franmomu, what about following the same strategy than https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/4.x/.github/workflows/test_orm_3.yaml ? gedmo/doctrine-extensions is an optional dev dependency, it should be a blocker for the ORM 3 support. |
Is there anything I can do to help this PR along? This bundle is holding up an ORM upgrade on our end, so I'm happy to help if I can. |
Basically, we need green tests. If you want you can recreate the same PR and add a github actions similar to https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/4.x/.github/workflows/test_orm_3.yaml Instead of removing AuditBundle you remove the doctrineExtensions. |
Subject
This PR tries to add support for
doctrine/orm
3I am targeting this branch, because these changes are BC.
Changelog
The CI should be modified to allow installing
doctrine/orm
3