vimeo#8363 - support static as a type parameter in return types of …

…the first-class callables
someniatko · Aug 4, 2022 · be02e7e · be02e7e
1 parent f3d6784
commit be02e7e
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 2 deletions.
diff --git a/...lm/Internal/Analyzer/Statements/Expression/Call/StaticMethod/AtomicStaticCallAnalyzer.php b/...lm/Internal/Analyzer/Statements/Expression/Call/StaticMethod/AtomicStaticCallAnalyzer.php
@@ -512,7 +512,18 @@ private static function handleNamedCall(
                 }
             }
 
-            $statements_analyzer->node_data->setType($stmt, $return_type_candidate);
+            $expanded_return_type = TypeExpander::expandUnion(
+                $codebase,
+                $return_type_candidate,
+                $context->self,
+                $class_storage->name,
+                $context->parent,
+                true,
+                false,
+                true
+            );
+
+            $statements_analyzer->node_data->setType($stmt, $expanded_return_type);
 
             return true;
         }

diff --git a/tests/ClosureTest.php b/tests/ClosureTest.php
@@ -751,7 +751,7 @@ public static function __callStatic(string $name, array $args): mixed {
                 [],
                 '8.1'
             ],
-            'FirstClassCallable:OverriddenStaticMethod' => [
+            'FirstClassCallable:InheritedStaticMethod' => [
                 '<?php
 
                     abstract class A
@@ -772,6 +772,34 @@ function takesIntToString(\Closure $_): void {}
                 [],
                 '8.1',
             ],
+            'FirstClassCallable:InheritedStaticMethodWithStaticTypeParameter' => [
+                '<?php
+
+                    /** @template T */
+                    class Holder
+                    {
+                        /** @param T $value */
+                        public function __construct(public $value) {}
+                    }
+
+                    abstract class A
+                    {
+                        final public function __construct(public int $i) {}
+
+                        /** @return Holder<static> */
+                        public static function create(int $i): Holder
+                        {
+                            return new Holder(new static($i));
+                        }
+                    }
+
+                    class C extends A {}
+
+                    /** @param \Closure(int):Holder<C> $_ */
+                    function takesIntToHolder(\Closure $_): void {}
+
+                    takesIntToHolder(C::create(...));'
+            ],
             'FirstClassCallable:WithArrayMap' => [
                 '<?php
                     $array = [1, 2, 3];