Sai/merged sets #535
Closed
Sai/merged sets #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiskee
commented
Mar 8, 2024
| @@ -240,7 +240,183 @@ func (s *{{ $kindLowerCamel }}Set) Clone() {{ $resource.Kind }}Set { | |||
| if s == nil { | |||
| return nil | |||
| } | |||
| return &{{ $kindLowerCamel }}Set{set: sksets.NewResourceSet(s.Generic().Clone().List()...)} | |||
| return &{{ $kindLowerCamel }}MergedSet{sets: []sksets.ResourceSet{s.Generic()}} | |||
There was a problem hiding this comment.
This is the main effective change, clone now produces a merged set, which is a a list of sets which is iterated through on methods like Find or List
saiskee
commented
Mar 8, 2024
pkg/ezkube/resource_id.go
Outdated
| @@ -152,6 +153,37 @@ func KeyWithSeparator(id ResourceId, separator string) string { | |||
| return b.String() | |||
| } | |||
|
|
|||
| func HashedKeyWithSeparator(id ResourceId, separator string) uint64 { | |||
There was a problem hiding this comment.
Using a uint64 for the key may reduce key building time and gc time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a thorough summary of the changes.
This fixes ... \ This new feature can be used to ...
Context
Summary of issue
Description and justification of any interesting decisions made